Upgrade the folder structure to use assets folder #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meddle0x53
reviewed
Mar 13, 2020
| @@ -0,0 +1,4 @@ | |||
| [ | |||
| import_deps: [:phoenix], | |||
There was a problem hiding this comment.
Good that you introduced the formatter!
config/dev.exs
Outdated
| @@ -34,5 +34,5 @@ config :logger, :error_log, path: "log/error.log", level: :error | |||
| config :phoenix, :stacktrace_depth, 20 | |||
|
|
|||
| config :blogit, | |||
| repository_url: "https://github.com/meddle0x53/blogit_sample", | |||
| repository_url: "https://github.com/9to1url/blogit_sample.git", | |||
There was a problem hiding this comment.
This should be left as it is?
mix.exs
Outdated
| deps: deps()] | ||
| [ | ||
| app: :blogit_web, | ||
| version: "0.14.0", |
mix.exs
Outdated
| {:phoenix_pubsub, "~> 1.0"}, | ||
| {:phoenix_html, "~> 2.6"}, | ||
| {:phoenix_live_reload, "~> 1.0", only: :dev}, | ||
| {:gettext, "~> 0.11"}, | ||
| {:cowboy, "~> 1.0"}, | ||
| {:poison, "~> 3.1.0"}, |
There was a problem hiding this comment.
Why do you need poison if Jason is used now?
There was a problem hiding this comment.
Poison been reference in endpoint.ex at 2018, if not adding this will not compile. I will remove the Poison at endpoint.ex and replace with Jason.
|
I tried the mix test, 10 failured. I also clone your original one and run mix test. it also failured 10. Any idea? |
|
Hi Meddle, |
|
Sorry it took me sometime to get back to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Last time upgrade to phx 1.4, this time also upgrade the folder structure and match phx 1.3/1.4.