Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Safari Doctors Youth Health Ambassadors app flavor. #372

Merged
merged 3 commits into from
Sep 18, 2024

Conversation

benkags
Copy link
Contributor

@benkags benkags commented Sep 9, 2024

contributes medic/safari-doctors#20

@antonykhaemba
Copy link
Member

Hi @eljhkrr, I tagging you here since the apk is needed by tomorrow - sorry I am not able to assign this PR to you.

@eljhkrr
Copy link
Member

eljhkrr commented Sep 12, 2024

@benkags Confirm whether signing secrets have been setup within the repository

@eljhkrr eljhkrr self-requested a review September 12, 2024 12:03
@eljhkrr
Copy link
Member

eljhkrr commented Sep 12, 2024

No worries @antonykhaemba, I've assigned myself

@benkags
Copy link
Contributor Author

benkags commented Sep 12, 2024

@eljhkrr The secrets have not been set up. Let me now how I can share them securely

{1C06F493-6333-44F9-9E25-95A9E9B4560E}

@eljhkrr eljhkrr requested review from billwambua and removed request for eljhkrr September 12, 2024 18:55
@eljhkrr
Copy link
Member

eljhkrr commented Sep 13, 2024

Reassigned to Wambua as I'll be away today

@billwambua
Copy link

billwambua commented Sep 13, 2024

@benkags can you upload to 1password and invite @eljhkrr and me.

Everything else looks good btw.

@antonykhaemba
Copy link
Member

Thanks @billwambua and @eljhkrr. @benkags had shared the secrets, please confirm if you received the apk secrets?

We were supposed to go live last Friday (Sep 13), can we please prioritize having this ready today. Thanks.

@benkags
Copy link
Contributor Author

benkags commented Sep 16, 2024

@billwambua I have shared the credentials via 1password. I have requested @eljhkrr 's email via email so that I can add him as well.

@billwambua
Copy link

@benkags I tried opening the link you shared on email but it says "Not available"

Screenshot from 2024-09-16 13-25-40

@billwambua
Copy link

@benkags for the 1Password invitation, you invited the wrong email. You are using the new shortened domain instead of the old medic domain which is what I created my 1Password account with.

This means I have to create a new account to join your invitation.

I have communicated with @antonykhaemba on the exact details you can use if you still don't understand what you need to do from the above.

He will forward to you.

@benkags
Copy link
Contributor Author

benkags commented Sep 16, 2024

Hi Bill, the BitWarden share expired.

@billwambua, I've shared with wa*@medicmobile.org address. Let me know if you can access now.

@billwambua
Copy link

billwambua commented Sep 16, 2024

@benkags I'm in the workspace you have invited me to, but I can't see any Safari Doctors items.

It's completely empty.

@benkags
Copy link
Contributor Author

benkags commented Sep 16, 2024

Your access was pending approval.

'View vault' so see the .env file uploaded.

safari doctors 1password vault

@billwambua
Copy link

@benkags I don't have the appropriate permissions to add the secrets to Github Actions.

@alexosugo can sort that.

@benkags
Copy link
Contributor Author

benkags commented Sep 17, 2024

@billwambua, thanks. I've standardized the naming.

@benkags benkags requested a review from billwambua September 17, 2024 07:31
Copy link

@billwambua billwambua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Go ahead with setting the CI variables.

Copy link
Contributor

@jkuester jkuester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benkags
Copy link
Contributor Author

benkags commented Sep 17, 2024

@jkuester I have shared the credentials in 1password to jk*@medic.org.

@jkuester
Copy link
Contributor

@benkags I received an email invite to make an account for your 1Password. I did that (and my user is jkuester.) But I cannot see any existing vault items. Could you try sharing them with my jkuester account?

@benkags
Copy link
Contributor Author

benkags commented Sep 17, 2024

Access was pending approval. Pleas try now. Check the vault items ford the .env file.

@mrjones-plip
Copy link
Collaborator

I've added these secrets:

  • ANDROID_KEYSTORE_PASSWORD_SAFARIDOCTORS_KENYA_YHA
  • ANDROID_KEY_PASSWORD_SAFARIDOCTORS_KENYA_YHA
  • ANDROID_SECRETS_IV_SAFARIDOCTORS_KENYA_YHA
  • ANDROID_SECRETS_KEY_SAFARIDOCTORS_KENYA_YHA

image

@jkuester jkuester merged commit 1ce2a9c into medic:master Sep 18, 2024
4 checks passed
@jkuester
Copy link
Contributor

Okay, I merged this to master and pushed a tag. The release artifacts (.apk and aab) are available here (look for the files cht-android-v1.4.0-safaridoctors_kenya_yha-publish.1-safaridoctors_kenya_yha-*).

@benkags
Copy link
Contributor Author

benkags commented Sep 18, 2024

I don't have access to this link. Are there additional privileges required. Is there another way to access the APKs before a release tag is created?

@mrjones-plip
Copy link
Collaborator

@benkags - sure thing! here's a zip file with all 5 of the build artifacts:

  • cht-android-v1.4.0-safaridoctors_kenya_yha-publish.1-safaridoctors_kenya-arm64-v8a-release.apk
  • cht-android-v1.4.0-safaridoctors_kenya_yha-publish.1-safaridoctors_kenya-armeabi-v7a-release.apk
  • cht-android-v1.4.0-safaridoctors_kenya_yha-publish.1-safaridoctors_kenya_yha-arm64-v8a-release.apk
  • cht-android-v1.4.0-safaridoctors_kenya_yha-publish.1-safaridoctors_kenya_yha-armeabi-v7a-release.apk
  • cht-android-v1.4.0-safaridoctors_kenya_yha-publish.1-safaridoctors_kenya_yha-release.aab

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants