Skip to content
This repository has been archived by the owner on Oct 30, 2023. It is now read-only.

Fix accounts.json example commenting in README.md #81

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Fix accounts.json example commenting in README.md #81

merged 1 commit into from
Feb 12, 2018

Conversation

ZeroMemes
Copy link
Contributor

Description

JSON standard doesn't support comments, and therefore JSON code blocks in markdown don't. (Indicated by the red highlighting that is seen in the comments). By saying that the block is JavaScript, we can get around this while still having proper syntax highlighting.

Type

Documentation

Checklist

  • I have read the CONTRIBUTING guide.
  • ./build.sh is passing with every build step and every test locally.
  • I have added tests that prove my fix is effective or that my feature works.
  • I tested it on Linux and on Windows and it's working as intended.

Discussion

N/A?

Reviewers

@Marc3842h

JSON standard doesn't support comments, and therefore JSON code blocks in markdown don't. (Indicated by the red highlighting that is seen in the comments). By saying that the block is JavaScript, we can get around this while still having proper syntax highlighting.
@mellowagain mellowagain added general: input wanted status: waiting Waiting for a response or work to be done on this issue... type: documentation labels Feb 12, 2018
@mellowagain
Copy link
Owner

mellowagain commented Feb 12, 2018

Json.NET, the library Titan uses to parse JSON, allows JSON comments by stripping them first out before parsing the file. I don't see a reason to remove it in that case.

Edit: Nevermind, you're doing a workaround in that case. Alright, that is fine. May I ask for your Discord name if you joined the Titan discord to award you the contributor role?

@mellowagain mellowagain merged commit cdff18e into mellowagain:master Feb 12, 2018
@mellowagain mellowagain added status: accepted and removed general: input wanted status: waiting Waiting for a response or work to be done on this issue... labels Feb 12, 2018
@ZeroMemes
Copy link
Contributor Author

My Discord name is Brady#4207

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants