Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Flipped Hybrid Screen Layout #1705

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

HetchBug
Copy link

@HetchBug HetchBug commented Jun 21, 2023

This commit added the "Flipped Hybrid" option to the screen layout options. It is similar to the "Hybrid" option but moves the large screen to the right and the two smaller screens to the left.
This feature will help for people who are right-handed (or left-handed!) using a touch screen on Steam Decks or similar devices. It works with all four rotations, swap screen option, and touch functionality.

Hybrid Layout:
Screenshot 2023-06-20 233722

Flipped Hybrid Layout:
Screenshot 2023-06-20 233735

Closes #1658

HetchBug added 2 commits June 21, 2023 16:25
This commit added the "Flipped Hybrid" option to the screen layout options. This will help for people who are right-handed using a touch screen on Steam Decks. This feature works with all four rotations and the touch functionality is calibrated correctly.
@RSDuck
Copy link
Member

RSDuck commented Jun 21, 2023

you're duplicating far too much code.

@HetchBug
Copy link
Author

you're duplicating far too much code.

I see what you mean. I'll have to retry when I have time. Thanks.

HetchBug added 3 commits June 21, 2023 21:47
There were far too many duplicated lines when there was no need, now the code works the same with fewer lines of code.
Choosing any gap option before would break the flipped hybrid layout. Now the layout works with each gap option to show the screens on the left and the screen on the right.
This removes the sharing of the "Swap screens" toggle for the hybrid layouts. The "Swap screens" toggle still exists, and a new  "Swap focused hybrid screen" toggle has been introduced. Now the user can swap the large main screen with "Swap focused hybrid screen" and separately swap the two smaller screens with each other using "Swap screens". This works with all rotations and gap options. It also includes a hotkey mapping in the settings.
@HetchBug
Copy link
Author

HetchBug commented Jun 27, 2023

I fixed up the duplicated code and ensured it works on Windows and Linux. On top of that, I just added a new toggle, which takes the place of how "Swap screens" worked with the hybrid layout. Now, the "Swap screens" toggle works the way it does in other layouts. The new toggle changes what the large screen displays (top/bottom). This addresses #1704 and includes hotkey support.

Quick reference for both hybrid layouts:

  • Swap screens: swap the two small screens with each other.
  • Swap focused hybrid screen: change large screen to show the top screen/bottom screen.

@user18081972
Copy link

I've always wanted this feature. Its good for left handed people.

@ttang4299
Copy link

@Jaklyy Sorry for the mention, but since you will be taking over soon, I was wondering if this can be merged for the 1.0 update. It's kind of an important feature for me, as otherwise, it wouldn't be ergonomic to use touch controls in some games on my Steam Deck.

@Jaklyy
Copy link
Contributor

Jaklyy commented Oct 26, 2024

don't have merge perms, but code looks fine to me? Needs to be updated to stop conflicting with master though.
I will say that i do believe we had plans of our own to eventually rework the way screen layouts work to support more user configurability? so i think in theory something like this would come as a result of that work. Though merging something like this as a stop gap in the meantime would be probably be fine if that rework doesn't end up coming in time for 1.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow magnified display in hybrid screen layout to move to the right
5 participants