Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind 'Toggle Fullscreen' hotkey to F11 by default #2095

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OpenSauce04
Copy link

@OpenSauce04 OpenSauce04 commented Jul 12, 2024

This pull request updates the default settings to bind the hotkey which toggles fullscreen to the F11 key.

I am proposing this due to my personal initial impression with the emulator, where I experienced immediate confusion on how I was supposed to full-screen the emulator. At first I tried pressing F11, as is convention with all software, and nothing happened. I then attempted to find a fullscreen toggle in various corners of the menu bar, to no effect.

This led to me having to use the internet to find out how to enter fullscreen, which lead to me finding a year old Reddit thread explaining that a hotkey existed and that many people were unnecessarily using command line parameters without knowing this information.

This seems like quite poor UX, so I believe that MelonDS should follow expected software convention and use the F11 key to enter fullscreen by default, as this is the behaviour that most users will assume.

I am unfamiliar with this codebase, so please correct me if I have approached implementing this incorrectly.

@Zection6V
Copy link

Zection6V commented Dec 8, 2024

Qt::Key_F11 may be better
{"Instance*.Keyboard.HK_FullscreenToggle", Qt::Key_F11},

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants