Add an About dialog with build info #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
how dose a master build look like , i assume the branch , will just mention master |
|
Yeah, it should just say |
nadiaholmquist
force-pushed
the
feature/about-dialog
branch
from
955dcec to
771521c
Compare
* display build info * make open URL buttons work * tweak layout a bit
nadiaholmquist
force-pushed
the
feature/about-dialog
branch
from
771521c to
5d11782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an About dialog showing the versions as well as credits to the melonDS team and build information.
The build information is specified at configure time using either environment variables or CMake options, to make it ideal for packaging and for GitHub Actions builds.
Here's how it currently looks:
Feedback on the UI as well as what build info it would be useful to include is very welcome.