-
Notifications
You must be signed in to change notification settings - Fork 750
11.3 RNs #10132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: development
Are you sure you want to change the base?
11.3 RNs #10132
Conversation
* If you connect to SQL Server using integrated security in a module such as [Database Connector](https://marketplace.mendix.com/link/component/2888), you may need to update the JDBC driver in `userlib` as well. | ||
- Maia for Pages now has knowledge about styling properties and can set and update their values. | ||
- When either the `X-Forwarded-Proto` or `X-Forwarded-Scheme` header is set to `http` cookies will now be set without the `secure` attribute, even if the `ApplicationRootUrl` is set to a secure URL. | ||
- In React Client, we now offer a quick fix for finding the usages of a select page configured for an association widget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll look into documenting this quick fix more explicitly.
- We have made several improvements to the modernized app explorer to enhance usability, performance, and stability. We have (temporarily) disabled the [Enter], [Left Arrow], and [Right Arrow] hotkeys on expandable nodes and [Left Arrow] on leaf nodes in the modernized app explorer. | ||
- We added `Check all` and `Uncheck all` functionality while selecting REST requests, when importing an OpenApi contract in Consumed Rest Services. | ||
- When creating a new branch, invalid characters (~ ^ : ? * [ \) are now automatically replaced by a dash (-) to adhere to Git's naming limitations. | ||
- Studio pro now replaces the invalid characters in branch name dialog with dashes as they are typed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are both these dash bullets valid, or duplications of each other?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've made a suggestion for combining them.
* An association in the database contained any dangling references | ||
* Foreign key constraints were newly enabled | ||
* The association storage was changed to or from being a direct association | ||
- We fixed an issue where a foreign key constraint violation in the database could result in a NullPointerException. (Ticket 258430) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The thing that broke 10.24.7
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe I should tweak the lang to be 1-1 as the other bullet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ConnorLand was this ever released in 11.x? If not there was nothing to fix and we should get rid of this, otherwise people will worry that there was a bug in 11.2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for new features and improvements.
Let me know if you have any questions.
* If you connect to SQL Server using integrated security in a module such as [Database Connector](https://marketplace.mendix.com/link/component/2888), you may need to update the JDBC driver in `userlib` as well. | ||
* Maia for Pages now has knowledge about styling properties and can set and update their values. | ||
* When either the `X-Forwarded-Proto` or `X-Forwarded-Scheme` header is set to `http` cookies will now be set without the `secure` attribute, even if the `ApplicationRootUrl` is set to a secure URL. | ||
* In React Client, we now offer a quick fix for finding the usages of a select page configured for an association widget. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should this be "the React Client"?
* When creating a new branch, invalid characters (~ ^ : ? * [ \) are now automatically replaced by a dash (-) to adhere to Git's naming limitations. | ||
* Studio pro now replaces the invalid characters in branch name dialog with dashes as they are typed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think these two are so similar they can be combined.
* When creating a new branch, invalid characters (~ ^ : ? * [ \) are now automatically replaced by a dash (-) to adhere to Git's naming limitations. | |
* Studio pro now replaces the invalid characters in branch name dialog with dashes as they are typed. | |
* When creating a new branch, invalid characters (~ ^ : ? * [ \) are now automatically replaced by a dash (-) to adhere to Git's naming limitations. This means that Studio Pro now replaces the invalid characters in branch name dialog with dashes as they are typed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ConnorLand
Finished reviewing the Fixes. Looks good, and I can't see any places that need more documentation.
I've made lots of very minor language changes which you can ignore if you want.
There are a couple of things which might be worth checking up on and a couple of places where things could be combined into a single fix.
* We fixed an issue where a user is asked to provide git credentials for Repository optimization. | ||
* We fixed an issue where user gets an **Oops** pop-up window when creating non-versioned app. | ||
* We fixed an issue with the icon of the security level dialog that the the dark-mode icon was visible in light-mode. | ||
* We fixed an issue where a "404 - file not found for file: .well-known%2Fappspecific%2Fcom.chrome.devtools.json" error was shown in the Studio Pro console when opening a React app in Chrome with dev tools open. This error was caused by Chrome's automatic workspace folders feature. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this %2F is a slash and this should be:
* We fixed an issue where a "404 - file not found for file: .well-known%2Fappspecific%2Fcom.chrome.devtools.json" error was shown in the Studio Pro console when opening a React app in Chrome with dev tools open. This error was caused by Chrome's automatic workspace folders feature. | |
* We fixed an issue where a "404 - file not found for file: .well-known/appspecific/com.chrome.devtools.json" error was shown in the Studio Pro console when opening a React app in Chrome with dev tools open. This error was caused by Chrome's automatic workspace folders feature. |
But probably best to check with the relevant team
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh right. Weird. I wonder if GitLab or something changed it.
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
Co-authored-by: Mark van Ments <[email protected]>
No description provided.