added unit-test and changelog note

menshen · Oct 20, 2014 · 1489869 · 1489869
1 parent db2478a
commit 1489869
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 0 deletions.
diff --git a/CHANGES b/CHANGES
@@ -46,6 +46,7 @@ v2.0.0 (TBA)
 -Fixed (issue #684) - Fixed issue with multiple ResPackages in ARSC file.
 -Fixed (issue #682) - Fixed handling renamed manifests with ("yi")
 -Fixed (issue #664) - Fixed issue with apks with large StringPools failing to decode.
+-Fixed (issue #447) - Fixed bad cast of ResStringValue to ResAtr by handling ResStringValue correctly (Thanks whydoubt)
 -Fixed issue with APKs with multiple dex files.
 -Fixed issue with using Apktool without smali/baksmali for ApktoolProperties (Thanks teprrr)
 -Fixed issue with non-URI standard characters in apk name (Thanks rover12421)

diff --git a/....apktool/apktool-lib/src/test/resources/brut/apktool/testapp/res/values-mcc001/styles.xml b/....apktool/apktool-lib/src/test/resources/brut/apktool/testapp/res/values-mcc001/styles.xml
@@ -6,6 +6,7 @@
     </style>
     <style name="TextAppearance.EditEvent_Button" parent="@style/TextAppearance.EditEvent_Label">
         <item name="android:textColor">#ff777777</item>
+        <item name="@string/issue_477">?android:dividerVertical</item>
     </style>
     <style name="Foo.Bar" parent=""/>
 </resources>
diff --git a/brut.apktool/apktool-lib/src/test/resources/brut/apktool/testapp/res/values/strings.xml b/brut.apktool/apktool-lib/src/test/resources/brut/apktool/testapp/res/values/strings.xml
@@ -2,4 +2,5 @@
 <resources>
     <string name="test1" />
     <string name="hello_world">Hello World</string>
+    <string name="issue_477">divider</string>
 </resources>