Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce TracksCache and simplify _match_files(), add test #2585

Merged
merged 1 commit into from
Feb 25, 2025

Conversation

zas
Copy link
Collaborator

@zas zas commented Feb 24, 2025

Summary

  • This is a…
    • Bug fix
    • Feature addition
    • Refactoring
    • Minor / simple change (like a typo)
    • Other
  • Describe this change in 1-2 sentences:

Problem

  • JIRA ticket (optional): PICARD-XXX

Solution

Action

Additional actions required:

  • Update Picard documentation (please include a reference to this PR)
  • Other (please specify below)

@zas zas requested a review from phw February 24, 2025 20:45
Copy link
Member

@phw phw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Sophist-UK
Copy link
Contributor

Sophist-UK commented Feb 25, 2025

I appreciate the name already existed, but not so much of a cache (which you might expect to be persistent) but more of a lookup table created afresh every time _match_files is run and destroyed when it finishes (because it is a local object).

Would TracksLookup be a better class name?

@zas
Copy link
Collaborator Author

zas commented Feb 25, 2025

Would TracksLookup be a better class name?

No strong opinion about this, it really works as a cache, even if it's temporary.
Feel free to make a PR for a rename.

@zas zas merged commit 19b42bc into metabrainz:master Feb 25, 2025
50 checks passed
@zas zas deleted the refactor_trackscache branch February 25, 2025 10:10
@Sophist-UK
Copy link
Contributor

LOL - not that bothered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants