fix: (wpengine#354) warning on widgets.php due to previewlinks.js (wp…

…engine#429) * fix: (wpengine#354) use `load-post-new.php`/`load-post.php` actions for previewlinks.js * test: (wpengine#354) test preview links action calls
metadsign · Sep 1, 2021 · 39322aa · 39322aa
1 parent 62171f9
commit 39322aa
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 9 deletions.
diff --git a/plugins/wpe-headless/includes/replacement/callbacks.php b/plugins/wpe-headless/includes/replacement/callbacks.php
@@ -204,14 +204,13 @@ function wpe_headless_term_link( $term_link ) {
 }
 
 
+add_action( 'load-post-new.php', 'wpe_headless_enqueue_preview_scripts' );
+add_action( 'load-post.php', 'wpe_headless_enqueue_preview_scripts' );
 /**
- * Adds JavaScript file to the Gutenberg editor page that prepends /preview to the preview link
+ * Adds JavaScript file to the Gutenberg editor page that prepends /preview to the preview link.
  *
  * XXX: Please remove this once this issue is resolved: https://github.com/WordPress/gutenberg/issues/13998
  */
-add_action(
-	'enqueue_block_editor_assets',
-	function() {
-		wp_enqueue_script( 'awp-gutenberg-filters', plugins_url( '/previewlinks.js', __FILE__ ), array( 'wp-edit-post' ), '1.0.0', true );
-	}
-);
+function wpe_headless_enqueue_preview_scripts() {
+	wp_enqueue_script( 'awp-gutenberg-filters', plugins_url( '/previewlinks.js', __FILE__ ), array(), '1.0.0', true );
+}
diff --git a/plugins/wpe-headless/includes/replacement/previewlinks.js b/plugins/wpe-headless/includes/replacement/previewlinks.js
@@ -9,7 +9,7 @@ window.addEventListener('DOMContentLoaded', function () {
         'button[class~="block-editor-post-preview__button-toggle"]',
       );
 
-      if (!previewButton) {
+      if (!previewButton.length) {
         return;
       }
 
@@ -20,7 +20,7 @@ window.addEventListener('DOMContentLoaded', function () {
             'a[target*="wp-preview"]',
           );
 
-		  if (!links) {
+		  if (!links.length) {
 			  return;
 		  }
 

diff --git a/plugins/wpe-headless/tests/integration/replacement/test-replacement-callbacks.php b/plugins/wpe-headless/tests/integration/replacement/test-replacement-callbacks.php
@@ -38,6 +38,11 @@ public function test_graphql_request_results_filter() {
 		$this->assertSame( 10, has_action( 'graphql_request_results', 'wpe_headless_url_replacement' ) );
 	}
 
+	public function test_enqueue_preview_scripts_action() {
+		$this->assertSame( 10, has_action( 'load-post-new.php', 'wpe_headless_enqueue_preview_scripts' ) );
+		$this->assertSame( 10, has_action( 'load-post.php', 'wpe_headless_enqueue_preview_scripts' ) );
+	}
+
 	/**
 	 * Tests wpe_headless_content_replacement() returns original value when content replacement is not enabled.
 	 */