Move error tests to separate test case.

mg6maciej · Apr 4, 2015 · bcac6e2 · bcac6e2
1 parent d099ba6
commit bcac6e2
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 20 deletions.
diff --git a/src/androidTest/java/pl/mg6/testsupport/ReparcelerErrorTestCase.java b/src/androidTest/java/pl/mg6/testsupport/ReparcelerErrorTestCase.java
@@ -0,0 +1,29 @@
+package pl.mg6.testsupport;
+
+import junit.framework.TestCase;
+
+import pl.mg6.testsupport.data.WithNonStaticCreator;
+import pl.mg6.testsupport.data.WithProtectedCreator;
+
+public class ReparcelerErrorTestCase extends TestCase {
+
+    private final Reparceler reparceler = new Reparceler();
+
+    public void testWithProtectedCreatorShouldFail() {
+        WithProtectedCreator original = new WithProtectedCreator();
+        ReparcelingResult<WithProtectedCreator> result = reparceler.reparcel(original);
+        assertSame(original, result.getOriginal());
+        assertNull(result.getReparceled());
+        assertTrue(result.getError() instanceof ReparcelingError);
+        assertEquals("Missing public static CREATOR field on class WithProtectedCreator.", result.getError().getMessage());
+    }
+
+    public void testWithoutCreatorShouldFail() {
+        WithNonStaticCreator original = new WithNonStaticCreator();
+        ReparcelingResult<WithNonStaticCreator> result = reparceler.reparcel(original);
+        assertSame(original, result.getOriginal());
+        assertNull(result.getReparceled());
+        assertTrue(result.getError() instanceof ReparcelingError);
+        assertEquals("Missing public static CREATOR field on class WithNonStaticCreator.", result.getError().getMessage());
+    }
+}
diff --git a/src/androidTest/java/pl/mg6/testsupport/ReparcelerTestCase.java b/src/androidTest/java/pl/mg6/testsupport/ReparcelerTestCase.java
@@ -13,8 +13,6 @@
 import pl.mg6.testsupport.data.Hrisey;
 import pl.mg6.testsupport.data.Parceler;
 import pl.mg6.testsupport.data.Simple;
-import pl.mg6.testsupport.data.WithNonStaticCreator;
-import pl.mg6.testsupport.data.WithProtectedCreator;
 
 public class ReparcelerTestCase extends TestCase {
 
@@ -63,22 +61,4 @@ public void testComplexParcelableShouldBeEqual() {
         assertTrue(result.areEqual());
         assertNull(result.getError());
     }
-
-    public void testWithProtectedCreatorShouldFail() {
-        WithProtectedCreator original = new WithProtectedCreator();
-        ReparcelingResult<WithProtectedCreator> result = reparceler.reparcel(original);
-        assertSame(original, result.getOriginal());
-        assertNull(result.getReparceled());
-        assertTrue(result.getError() instanceof ReparcelingError);
-        assertEquals("Missing public static CREATOR field on class WithProtectedCreator.", result.getError().getMessage());
-    }
-
-    public void testWithoutCreatorShouldFail() {
-        WithNonStaticCreator original = new WithNonStaticCreator();
-        ReparcelingResult<WithNonStaticCreator> result = reparceler.reparcel(original);
-        assertSame(original, result.getOriginal());
-        assertNull(result.getReparceled());
-        assertTrue(result.getError() instanceof ReparcelingError);
-        assertEquals("Missing public static CREATOR field on class WithNonStaticCreator.", result.getError().getMessage());
-    }
 }