animation engine integration: fix flickering: small optimization

Let's try to skip same time values. Signed-off-by: Marco Cecchetti <[email protected]> Change-Id: I318da7d6ff5c31198d1d94d679129ea0c3772512
mhoffmann75 · Sep 5, 2024 · d15f0e7 · d15f0e7
1 parent 7090969
commit d15f0e7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/browser/src/slideshow/Transition2d.ts b/browser/src/slideshow/Transition2d.ts
@@ -30,6 +30,7 @@ abstract class TransitionBase extends SlideChangeGl {
 	}
 
 	public startTransition(): void {
+		this.prevTime = null;
 		this.time = null;
 		this.isLastFrame = false;
 		this.requestAnimationFrameId = requestAnimationFrame(this.animate.bind(this));

diff --git a/browser/src/slideshow/engine/SlideChangeBase.ts b/browser/src/slideshow/engine/SlideChangeBase.ts
@@ -26,6 +26,7 @@ function SlideChangeTemplate<T extends AGConstructor<any>>(BaseType: T) {
 		protected leavingSlide: WebGLTexture | ImageBitmap;
 		protected enteringSlide: WebGLTexture | ImageBitmap;
 		protected time: number;
+		protected prevTime: number;
 		protected isLastFrame: boolean;
 
 		constructor(...args: any[]) {
@@ -42,6 +43,7 @@ function SlideChangeTemplate<T extends AGConstructor<any>>(BaseType: T) {
 			this.isFinished = false;
 			this.requestAnimationFrameId = null;
 			this.time = null;
+			this.prevTime = null;
 			this.isLastFrame = false;
 		}
 
@@ -64,12 +66,13 @@ function SlideChangeTemplate<T extends AGConstructor<any>>(BaseType: T) {
 
 		public perform(nT: number, last: boolean = false): void {
 			if (this.isFinished) return;
+			this.prevTime = this.time;
 			this.time = nT;
 			this.isLastFrame = last;
 		}
 
 		protected animate() {
-			if (this.time != null) {
+			if (this.time !== null && this.time !== this.prevTime) {
 				this.render(this.time);
 			}
 			if (!this.isLastFrame)