Skip to content

Commit

Permalink
ARM: 8367/1: sa1100: prepare for moving irq driver to drivers/irqchip
Browse files Browse the repository at this point in the history
Prepare for moving sa1100 irq driver to irqchip infrastructure - split
sa1100_init_irq into helper code and irq parts.

Signed-off-by: Dmitry Eremin-Solenikov <[email protected]>
Acked-by: Thomas Gleixner <[email protected]>
Signed-off-by: Russell King <[email protected]>
  • Loading branch information
lumag authored and Russell King committed May 28, 2015
1 parent 60c06c4 commit 85e6f09
Show file tree
Hide file tree
Showing 3 changed files with 36 additions and 15 deletions.
13 changes: 13 additions & 0 deletions arch/arm/mach-sa1100/generic.c
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
#include <linux/ioport.h>
#include <linux/platform_device.h>
#include <linux/reboot.h>
#include <linux/irqchip/irq-sa11x0.h>

#include <video/sa1100fb.h>

Expand Down Expand Up @@ -377,6 +378,18 @@ void __init sa1100_timer_init(void)
pxa_timer_nodt_init(IRQ_OST0, io_p2v(0x90000000), 3686400);
}

static struct resource irq_resource =
DEFINE_RES_MEM_NAMED(0x90050000, SZ_64K, "irqs");

void __init sa1100_init_irq(void)
{
request_resource(&iomem_resource, &irq_resource);

sa11x0_init_irq_nodt(IRQ_GPIO0_SC, irq_resource.start);

sa1100_init_gpio();
}

/*
* Disable the memory bus request/grant signals on the SA1110 to
* ensure that we don't receive spurious memory requests. We set
Expand Down
21 changes: 6 additions & 15 deletions arch/arm/mach-sa1100/irq.c
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
/*
* linux/arch/arm/mach-sa1100/irq.c
*
* Copyright (C) 2015 Dmitry Eremin-Solenikov
* Copyright (C) 1999-2001 Nicolas Pitre
*
* Generic IRQ handling for the SA11x0, GPIO 11-27 IRQ demultiplexing.
* Generic IRQ handling for the SA11x0.
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
Expand All @@ -15,16 +16,13 @@
#include <linux/io.h>
#include <linux/irq.h>
#include <linux/irqdomain.h>
#include <linux/ioport.h>
#include <linux/syscore_ops.h>
#include <linux/irqchip/irq-sa11x0.h>

#include <soc/sa1100/pwer.h>

#include <mach/irqs.h>
#include <asm/exception.h>

#include "generic.h"

#define ICIP 0x00 /* IC IRQ Pending reg. */
#define ICMR 0x04 /* IC Mask Reg. */
#define ICLR 0x08 /* IC Level Reg. */
Expand Down Expand Up @@ -86,9 +84,6 @@ static struct irq_domain_ops sa1100_normal_irqdomain_ops = {

static struct irq_domain *sa1100_normal_irqdomain;

static struct resource irq_resource =
DEFINE_RES_MEM_NAMED(0x90050000, SZ_64K, "irqs");

static struct sa1100irq_state {
unsigned int saved;
unsigned int icmr;
Expand Down Expand Up @@ -156,11 +151,9 @@ sa1100_handle_irq(struct pt_regs *regs)
} while (1);
}

void __init sa1100_init_irq(void)
void __init sa11x0_init_irq_nodt(int irq_start, resource_size_t io_start)
{
request_resource(&iomem_resource, &irq_resource);

iobase = ioremap(irq_resource.start, SZ_64K);
iobase = ioremap(io_start, SZ_64K);
if (WARN_ON(!iobase))
return;

Expand All @@ -177,10 +170,8 @@ void __init sa1100_init_irq(void)
writel_relaxed(1, iobase + ICCR);

sa1100_normal_irqdomain = irq_domain_add_simple(NULL,
32, IRQ_GPIO0_SC,
32, irq_start,
&sa1100_normal_irqdomain_ops, NULL);

set_handle_irq(sa1100_handle_irq);

sa1100_init_gpio();
}
17 changes: 17 additions & 0 deletions include/linux/irqchip/irq-sa11x0.h
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/*
* Generic IRQ handling for the SA11x0.
*
* Copyright (C) 2015 Dmitry Eremin-Solenikov
* Copyright (C) 1999-2001 Nicolas Pitre
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License version 2 as
* published by the Free Software Foundation.
*/

#ifndef __INCLUDE_LINUX_IRQCHIP_IRQ_SA11x0_H
#define __INCLUDE_LINUX_IRQCHIP_IRQ_SA11x0_H

void __init sa11x0_init_irq_nodt(int irq_start, resource_size_t io_start);

#endif

0 comments on commit 85e6f09

Please sign in to comment.