Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

log exceptions on non-api fails #198

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsnowlan
Copy link

If not using debug mode, non-JsonApiExceptions are only returned to the requestor and not logged. This makes it difficult to detect when requests are failing and what is causing the exceptions.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 90.424% when pulling 730094c on tsnowlan:frj-log-exceptions into a4ff3f4 on miLibris:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.008%) to 90.424% when pulling 730094c on tsnowlan:frj-log-exceptions into a4ff3f4 on miLibris:master.

@mahenzon
Copy link

Hi @tsnowlan! We maintain an upgraded fork Flask-COMBO-JSONAPI and already have such fix. Please take a look:

https://github.com/AdCombo/flask-combo-jsonapi/blob/b6303f3afda82eed8e2e5e3146f5d21e196231e4/flask_combo_jsonapi/decorators.py#L92-L94

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants