Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proxy for platform browser #53

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

Conversation

one-github
Copy link

@one-github one-github commented Jul 9, 2020

Since we use this plugin for testing our Cordova app in the browser, this proxy comes in handy as it functionally provides the same API as it does natively on the other platforms. It uses localStorage to store the data. By nature this is not secure so only use this for testing.

@alvis
Copy link

alvis commented Jul 22, 2020

I was developing using @ionic-native/secure-storage which uses this plugin and tried to test on a browser. I assumed localStorage will be used as a fallback for testing according to README, but it didn't. I thought it's my fault and spent an hour to research until I realise that it hasn't implemented for 5 years!

Thanks for proposing this PR and hope it can be merged soon.

@mibrito707 mibrito707 self-assigned this Aug 11, 2020
@mibrito707 mibrito707 added the enhancement New feature or request label Aug 11, 2020
@EKashpersky
Copy link

@mibrito707 can't it be merged? I've faced same problem just as @alvis did, and the MR been open for a while...

I'd be glad to help out if anything, I also need this thing working. For now just implementing fallback on app-level

@silviuburceadev
Copy link

@mibrito707 can we restore browser support? Just like @one-github and @EKashpersky, I'm happy to help if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants