Merge pull request adobe#4588 from adobe/pflynn/pluggable-linting

Pluggable linting
micole · Sep 7, 2013 · db4e426 · db4e426
2 parents 13d785c + 3dd1b3f
commit db4e426
Show file tree

Hide file tree

Showing 20 changed files with 493 additions and 360 deletions.
diff --git a/src/base-config/keyboard.json b/src/base-config/keyboard.json
@@ -225,6 +225,15 @@
     "navigate.jumptoDefinition":  [
         "Ctrl-J"
     ],
+    "navigate.gotoFirstProblem":  [
+        {
+            "key": "F8"
+        },
+        {
+            "key": "Cmd-'",
+            "platform": "mac"
+        }
+    ],
     "navigate.nextDoc":  [
         {
             "key": "Ctrl-Tab"

diff --git a/src/brackets.config.json b/src/brackets.config.json
@@ -15,6 +15,7 @@
         "contributors_url"  : "https://api.github.com/repos/adobe/brackets/contributors",
         "extension_wiki_url": "https://github.com/adobe/brackets/wiki/Brackets-Extensions",
         "extension_registry": "https://s3.amazonaws.com/extend.brackets/registry.json",
-        "extension_url"     : "https://s3.amazonaws.com/extend.brackets/{0}/{0}-{1}.zip"
+        "extension_url"     : "https://s3.amazonaws.com/extend.brackets/{0}/{0}-{1}.zip",
+        "linting.enabled_by_default" : true
     }
 }
diff --git a/src/brackets.js b/src/brackets.js
@@ -97,8 +97,9 @@ define(function (require, exports, module) {
         ExtensionUtils          = require("utils/ExtensionUtils"),
         DragAndDrop             = require("utils/DragAndDrop"),
         ColorUtils              = require("utils/ColorUtils"),
+        CodeInspection          = require("language/CodeInspection"),
         NativeApp               = require("utils/NativeApp");
-            
+
     // Load modules that self-register and just need to get included in the main project
     require("command/DefaultMenus");
     require("document/ChangedDocumentTracker");
@@ -145,6 +146,7 @@ define(function (require, exports, module) {
             CodeHintManager         : CodeHintManager,
             Dialogs                 : Dialogs,
             DefaultDialogs          : DefaultDialogs,
+            CodeInspection          : CodeInspection,
             CSSUtils                : require("language/CSSUtils"),
             LiveDevelopment         : require("LiveDevelopment/LiveDevelopment"),
             LiveDevServerManager    : require("LiveDevelopment/LiveDevServerManager"),

diff --git a/src/command/Commands.js b/src/command/Commands.js
@@ -88,6 +88,7 @@ define(function (require, exports, module) {
     exports.VIEW_RESTORE_FONT_SIZE      = "view.restoreFontSize";
     exports.VIEW_SCROLL_LINE_UP         = "view.scrollLineUp";
     exports.VIEW_SCROLL_LINE_DOWN       = "view.scrollLineDown";
+    exports.VIEW_TOGGLE_INSPECTION      = "view.toggleCodeInspection";
     exports.TOGGLE_LINE_NUMBERS         = "view.toggleLineNumbers";
     exports.TOGGLE_ACTIVE_LINE          = "view.toggleActiveLine";
     exports.TOGGLE_WORD_WRAP            = "view.toggleWordWrap";
@@ -105,6 +106,7 @@ define(function (require, exports, module) {
     exports.NAVIGATE_JUMPTO_DEFINITION  = "navigate.jumptoDefinition";
     exports.NAVIGATE_GOTO_DEFINITION    = "navigate.gotoDefinition";
     exports.NAVIGATE_GOTO_LINE          = "navigate.gotoLine";
+    exports.NAVIGATE_GOTO_FIRST_PROBLEM = "navigate.gotoFirstProblem";
     exports.TOGGLE_QUICK_EDIT           = "navigate.toggleQuickEdit";
     exports.TOGGLE_QUICK_DOCS           = "navigate.toggleQuickDocs";
     exports.QUICK_EDIT_NEXT_MATCH       = "navigate.nextMatch";

diff --git a/src/command/DefaultMenus.js b/src/command/DefaultMenus.js
@@ -116,6 +116,8 @@ define(function (require, exports, module) {
         menu.addMenuItem(Commands.TOGGLE_WORD_WRAP);
         menu.addMenuDivider();
         menu.addMenuItem(Commands.FILE_LIVE_HIGHLIGHT);
+        menu.addMenuDivider();
+        menu.addMenuItem(Commands.VIEW_TOGGLE_INSPECTION);
 
         /*
          * Navigate menu
@@ -125,6 +127,7 @@ define(function (require, exports, module) {
         menu.addMenuItem(Commands.NAVIGATE_GOTO_LINE);
         menu.addMenuItem(Commands.NAVIGATE_GOTO_DEFINITION);
         menu.addMenuItem(Commands.NAVIGATE_JUMPTO_DEFINITION);
+        menu.addMenuItem(Commands.NAVIGATE_GOTO_FIRST_PROBLEM);
         menu.addMenuDivider();
         menu.addMenuItem(Commands.NAVIGATE_NEXT_DOC);
         menu.addMenuItem(Commands.NAVIGATE_PREV_DOC);

diff --git a/src/config.json b/src/config.json
@@ -14,7 +14,8 @@
         "contributors_url": "https://api.github.com/repos/adobe/brackets/contributors",
         "extension_wiki_url": "https://github.com/adobe/brackets/wiki/Brackets-Extensions",
         "extension_registry": "https://s3.amazonaws.com/extend.brackets/registry.json",
-        "extension_url": "https://s3.amazonaws.com/extend.brackets/{0}/{0}-{1}.zip"
+        "extension_url": "https://s3.amazonaws.com/extend.brackets/{0}/{0}-{1}.zip",
+        "linting.enabled_by_default" : true
     },
     "name": "Brackets",
     "version": "0.31.0-0",

diff --git a/src/extensions/default/JSLint/config.json b/src/extensions/default/JSLint/config.json
diff --git a/src/extensions/default/JSLint/jslint.css b/src/extensions/default/JSLint/jslint.css
diff --git a/src/extensions/default/JSLint/keyboard.json b/src/extensions/default/JSLint/keyboard.json