adds session-cookie boolean configuration #1906
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, there was already an expiration date. This PR adds a configuration option to define. whether the cookie is a [session cookie](https://en.wikipedia.org/wiki/HTTP_cookie#Expires_and_Max-Age). A session cookie does not have an expiration date. When set to true, then no Expires atttribute is set for the cookie, making it an session cookie. Close: #339
sdelamo
commented
Jan 8, 2025
...ity-jwt/src/test/java/io/micronaut/security/token/jwt/cookie/JwtCookieSessionCookieTest.java
Outdated
Show resolved
Hide resolved
…kie/JwtCookieSessionCookieTest.java
….1 (#1905) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
This pull request extracts two methods to ease TokenCookieLoginHandler bean replacement. see: #339
|
n0tl3ss
approved these changes
Jan 8, 2025
yawkat
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/HTTP/Cookies
Currently, we set an expiration date for the cookie if no expiration date was defined in the configuration. We set the cookie containing the JWT as the value, with an expiration date matching the JWT
expclaim.Thus, users can't leave the expiration date empty and, therefore, configure a token cookie as a session cookie. Some users asked for this.
This PR adds a configuration option to define whether a cookie is a session cookie. When set to true, then no Expires attribute is set for the cookie, making it a session cookie.
Close: #339