Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete pip install fastBPE in README.md #30

Merged

Conversation

yuta519
Copy link
Contributor

@yuta519 yuta519 commented Feb 3, 2023

Thank you for providing great code as an oss project. There is one suggestion because I got an error when I set up BioGPT.

 $ pip install fastBPE

Collecting fastBPE
  Downloading fastBPE-0.1.0.tar.gz (35 kB)
  Preparing metadata (setup.py) ... done
Building wheels for collected packages: fastBPE
  Building wheel for fastBPE (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py bdist_wheel did not run successfully.
  │ exit code: 1
  ╰─> [212 lines of output]
      running bdist_wheel
      running build
      running build_py
      warning: build_py: byte-compiling is disabled, skipping.

      running build_ext
      building 'fastBPE' extension
      creating build
      creating build/temp.macosx-12.6-arm64-cpython-310
      creating build/temp.macosx-12.6-arm64-cpython-310/fastBPE
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Users/yuta519/.local/share/virtualenvs/bio-c43PJldc/include -I/Users/yuta519/.pyenv/versions/3.10.6/include/python3.10 -c fastBPE/fastBPE.cpp -o build/temp.macosx-12.6-arm64-cpython-310/fastBPE/fastBPE.o -std=c++11 -Ofast -pthread
      In file included from fastBPE/fastBPE.cpp:610:
      fastBPE/fastBPE.hpp:84:68: warning: format specifies type 'unsigned long' but the argument has type 'uint64_t' (aka 'unsigned long long') [-Wformat]
        fprintf(stderr, "Read %lu words (%lu unique) from text file.\n", total,
                              ~~~                                        ^~~~~
                              %llu
 
   ...

From fastBPE README, I thought pip install fastBPE is not necessary.

@renqianluo renqianluo merged commit 320c6f7 into microsoft:main Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants