Don't return tags when returning quick info for JSDoc nodes
#59816
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Andarist
commented
Sep 1, 2024
| //// */ | ||
| //// function foo(x/*2*/) {} | ||
|
|
||
| verify.quickInfoAt("1", "(parameter) x: any", "Does the thing", undefined); |
There was a problem hiding this comment.
This implements the change described by @mjbvz here. Maybe some JSDoc tags should be returned when requesting quick info for a JSDoc node? I don't know when it would be desirable though. It seems that they always describe an associated node and not itself. The "itself" description gets still returned as part of the documentation string
Andarist
commented
Sep 1, 2024
| //// function foo(x/*2*/) {} | ||
|
|
||
| verify.quickInfoAt("1", "(parameter) x: any", "Does the thing", undefined); | ||
| verify.quickInfoAt("2", "(parameter) x: any", "Does the thing", [{ name: "param", text: "x Does the thing" }]); |
There was a problem hiding this comment.
I think that this isn't particularly desirable result either. It still contains duplicate information. I think this should be fixed as part of #57819 though and not here
jakebailey
reviewed
Jun 30, 2025
jakebailey
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #59402