Fix RegExpIndicesArray by adding undefined to type definition #61079

stefnotch · 2025-01-29T21:24:31Z

RyanCavanaugh · 2025-02-04T20:18:59Z

typescript-bot · 2025-02-04T20:19:04Z

Starting jobs; this comment will be updated as builds start and complete.

Command	Status	Results
`test top400`	✅ Started	👀 Results
`user test this`	✅ Started	👀 Results
`run dt`	✅ Started	✅ Results
`perf test this faster`	✅ Started	👀 Results

typescript-bot · 2025-02-04T20:41:47Z

Hey @RyanCavanaugh, the results of running the DT tests are ready.

Everything looks the same!

You can check the log here.

typescript-bot · 2025-02-04T20:42:05Z

@RyanCavanaugh Here are the results of running the user tests with tsc comparing main and refs/pull/61079/merge:

Something interesting changed - please have a look.

Details

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

[NEW] error TS2345: Argument of type '() => ts.AwaitExpression' is not assignable to parameter of type '(traversal: TransformTraversalControl) => Node'.
- /mnt/ts_downloads/_/m/azure-sdk/src/util/admin/migrate-package/codemods/replaceChaiAsPromised.ts(48,26)

typescript-bot · 2025-02-04T21:06:57Z

@RyanCavanaugh
The results of the perf run you requested are in!

Here they are:

tsc

Comparison Report - baseline..pr

_Metric	_baseline	_pr	_Delta	_Best	_Worst	_p-value
_{Compiler-Unions - node (v18.15.0, x64)}
_Errors	₃₄	₃₄	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_62,390	_62,390	_~	_~	_~	_{p=1.000 n=6}
_Types	_50,395	_50,395	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{193,127k (± 0.02%)}	_{193,787k (± 0.76%)}	_~	_193,070k	_196,758k	_{p=1.000 n=6}
_{Parse Time}	_{1.31s (± 1.04%)}	_{1.30s (± 0.63%)}	_~	_1.29s	_1.31s	_{p=0.111 n=6}
_{Bind Time}	_0.73s	_0.73s	_~	_~	_~	_{p=1.000 n=6}
_{Check Time}	_{9.76s (± 0.31%)}	_{9.74s (± 0.37%)}	_~	_9.71s	_9.79s	_{p=0.295 n=6}
_{Emit Time}	_{2.73s (± 0.54%)}	_{2.72s (± 1.16%)}	_~	_2.66s	_2.75s	_{p=0.623 n=6}
_{Total Time}	_{14.53s (± 0.31%)}	_{14.48s (± 0.44%)}	_~	_14.39s	_14.56s	_{p=0.421 n=6}
_{angular-1 - node (v18.15.0, x64)}
_Errors	₃₇	₃₇	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_948,488	_948,488	_~	_~	_~	_{p=1.000 n=6}
_Types	_411,006	_411,006	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{1,225,437k (± 0.00%)}	_{1,225,439k (± 0.00%)}	_~	_1,225,383k	_1,225,509k	_{p=1.000 n=6}
_{Parse Time}	_{6.65s (± 0.86%)}	_{6.65s (± 0.85%)}	_~	_6.56s	_6.71s	_{p=1.000 n=6}
_{Bind Time}	_{1.89s (± 0.78%)}	_{1.89s (± 0.40%)}	_~	_1.88s	_1.90s	_{p=0.620 n=6}
_{Check Time}	_{31.91s (± 0.18%)}	_{32.04s (± 0.21%)}	_{+0.13s (+ 0.42%)}	_31.93s	_32.12s	_{p=0.013 n=6}
_{Emit Time}	_{15.17s (± 0.54%)}	_{15.21s (± 0.30%)}	_~	_15.12s	_15.24s	_{p=0.173 n=6}
_{Total Time}	_{55.61s (± 0.28%)}	_{55.79s (± 0.16%)}	_~	_55.66s	_55.87s	_{p=0.065 n=6}
_{mui-docs - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_2,447,815	_2,447,815	_~	_~	_~	_{p=1.000 n=6}
_Types	_898,759	_898,759	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,310,423k (± 0.00%)}	_{2,310,426k (± 0.00%)}	_~	_2,310,386k	_2,310,474k	_{p=1.000 n=6}
_{Parse Time}	_{8.93s (± 0.20%)}	_{8.93s (± 0.36%)}	_~	_8.90s	_8.98s	_{p=0.808 n=6}
_{Bind Time}	_{2.16s (± 0.29%)}	_{2.17s (± 0.57%)}	_~	_2.14s	_2.17s	_{p=0.116 n=6}
_{Check Time}	_{74.42s (± 0.38%)}	_{74.20s (± 0.39%)}	_~	_73.86s	_74.62s	_{p=0.298 n=6}
_{Emit Time}	_{0.28s (± 2.67%)}	_{0.28s (± 2.70%)}	_~	_0.27s	_0.29s	_{p=0.487 n=6}
_{Total Time}	_{85.79s (± 0.31%)}	_{85.57s (± 0.33%)}	_~	_85.29s	_85.99s	_{p=0.298 n=6}
_{self-build-src - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{2,362,143k (± 0.02%)}	_{2,361,769k (± 0.03%)}	_~	_2,360,791k	_2,362,686k	_{p=0.471 n=6}
_{Parse Time}	_{5.21s (± 0.94%)}	_{5.19s (± 0.89%)}	_~	_5.13s	_5.27s	_{p=0.521 n=6}
_{Bind Time}	_{1.79s (± 0.35%)}	_{1.79s (± 0.99%)}	_~	_1.75s	_1.80s	_{p=1.000 n=6}
_{Check Time}	_{35.25s (± 0.28%)}	_{35.24s (± 0.20%)}	_~	_35.16s	_35.33s	_{p=0.810 n=6}
_{Emit Time}	_{3.01s (± 1.27%)}	_{2.99s (± 1.00%)}	_~	_2.97s	_3.05s	_{p=0.334 n=6}
_{Total Time}	_{45.27s (± 0.33%)}	_{45.22s (± 0.19%)}	_~	_45.14s	_45.37s	_{p=0.630 n=6}
_{self-build-src-public-api - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_1,229,397	_1,229,397	_~	_~	_~	_{p=1.000 n=6}
_Types	_267,085	_267,085	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{3,038,432k (± 9.75%)}	_{3,039,742k (± 9.73%)}	_~	_2,435,401k	_3,161,527k	_{p=0.173 n=6}
_{Parse Time}	_{7.02s (± 1.39%)}	_{7.00s (± 1.05%)}	_~	_6.91s	_7.10s	_{p=0.748 n=6}
_{Bind Time}	_{2.15s (± 2.11%)}	_{2.15s (± 0.63%)}	_~	_2.14s	_2.18s	_{p=0.871 n=6}
_{Check Time}	_{42.93s (± 0.57%)}	_{43.02s (± 0.43%)}	_~	_42.82s	_43.29s	_{p=0.810 n=6}
_{Emit Time}	_{3.51s (± 1.66%)}	_{3.53s (± 2.76%)}	_~	_3.43s	_3.69s	_{p=0.936 n=6}
_{Total Time}	_{55.60s (± 0.58%)}	_{55.69s (± 0.46%)}	_~	_55.38s	_56.08s	_{p=0.936 n=6}
_{self-compiler - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_263,074	_263,074	_~	_~	_~	_{p=1.000 n=6}
_Types	_106,881	_106,881	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{441,322k (± 0.01%)}	_{441,298k (± 0.02%)}	_~	_441,182k	_441,389k	_{p=0.810 n=6}
_{Parse Time}	_{3.55s (± 1.39%)}	_{3.55s (± 1.09%)}	_~	_3.50s	_3.60s	_{p=0.627 n=6}
_{Bind Time}	_{1.32s (± 1.00%)}	_{1.31s (± 0.57%)}	_~	_1.30s	_1.32s	_{p=0.094 n=6}
_{Check Time}	_{19.07s (± 0.55%)}	_{19.03s (± 0.30%)}	_~	_18.92s	_19.07s	_{p=0.573 n=6}
_{Emit Time}	_{1.55s (± 1.46%)}	_{1.53s (± 0.99%)}	_~	_1.50s	_1.54s	_{p=0.167 n=6}
_{Total Time}	_{25.48s (± 0.46%)}	_{25.42s (± 0.27%)}	_~	_25.30s	_25.50s	_{p=0.336 n=6}
_{ts-pre-modules - node (v18.15.0, x64)}
_Errors	₇₀	₇₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_226,113	_226,113	_~	_~	_~	_{p=1.000 n=6}
_Types	_94,488	_94,488	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{371,726k (± 0.01%)}	_{371,804k (± 0.02%)}	_{+78k (+ 0.02%)}	_371,725k	_371,917k	_{p=0.045 n=6}
_{Parse Time}	_{2.88s (± 1.47%)}	_{2.88s (± 0.89%)}	_~	_2.86s	_2.93s	_{p=0.809 n=6}
_{Bind Time}	_{1.60s (± 1.48%)}	_{1.60s (± 1.44%)}	_~	_1.57s	_1.63s	_{p=1.000 n=6}
_{Check Time}	_{16.42s (± 0.31%)}	_{16.41s (± 0.22%)}	_~	_16.35s	_16.46s	_{p=0.567 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{20.90s (± 0.50%)}	_{20.89s (± 0.21%)}	_~	_20.85s	_20.96s	_{p=0.936 n=6}
_{vscode - node (v18.15.0, x64)}
_Errors	₃	₅	_{🔻+2 (+66.67%)}	_~	_~	_{p=0.001 n=6}
_Symbols	_3,274,571	_3,274,571	_~	_~	_~	_{p=1.000 n=6}
_Types	_1,126,273	_1,126,275	_{+2 (+ 0.00%)}	_~	_~	_{p=0.001 n=6}
_{Memory used}	_{3,349,300k (± 0.01%)}	_{3,349,501k (± 0.01%)}	_~	_3,348,874k	_3,349,731k	_{p=0.298 n=6}
_{Parse Time}	_{14.56s (± 0.46%)}	_{14.54s (± 0.43%)}	_~	_14.44s	_14.61s	_{p=0.748 n=6}
_{Bind Time}	_{4.60s (± 0.83%)}	_{4.58s (± 0.57%)}	_~	_4.56s	_4.63s	_{p=0.224 n=6}
_{Check Time}	_{89.50s (± 2.94%)}	_{88.68s (± 1.29%)}	_~	_87.80s	_90.97s	_{p=0.936 n=6}
_{Emit Time}	_{28.22s (± 2.93%)}	_{27.63s (± 2.37%)}	_~	_27.24s	_28.96s	_{p=0.109 n=6}
_{Total Time}	_{136.88s (± 1.91%)}	_{135.44s (± 0.86%)}	_~	_134.29s	_137.36s	_{p=0.575 n=6}
_{webpack - node (v18.15.0, x64)}
_Errors	₀	₀	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_292,529	_292,529	_~	_~	_~	_{p=1.000 n=6}
_Types	_119,113	_119,113	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{446,144k (± 0.03%)}	_{446,054k (± 0.02%)}	_~	_445,934k	_446,135k	_{p=0.230 n=6}
_{Parse Time}	_{4.07s (± 0.94%)}	_{4.07s (± 1.09%)}	_~	_4.01s	_4.13s	_{p=1.000 n=6}
_{Bind Time}	_{1.78s (± 0.79%)}	_{1.78s (± 0.50%)}	_~	_1.77s	_1.79s	_{p=1.000 n=6}
_{Check Time}	_{18.86s (± 0.45%)}	_{18.79s (± 0.66%)}	_~	_18.57s	_18.95s	_{p=0.228 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{24.71s (± 0.44%)}	_{24.64s (± 0.35%)}	_~	_24.50s	_24.76s	_{p=0.148 n=6}
_{xstate-main - node (v18.15.0, x64)}
_Errors	₅	₅	_~	_~	_~	_{p=1.000 n=6}
_Symbols	_555,375	_555,375	_~	_~	_~	_{p=1.000 n=6}
_Types	_186,146	_186,146	_~	_~	_~	_{p=1.000 n=6}
_{Memory used}	_{494,570k (± 0.01%)}	_{494,530k (± 0.01%)}	_~	_494,473k	_494,579k	_{p=0.378 n=6}
_{Parse Time}	_{4.25s (± 0.54%)}	_{4.24s (± 0.57%)}	_~	_4.20s	_4.27s	_{p=0.416 n=6}
_{Bind Time}	_{1.47s (± 0.71%)}	_{1.48s (± 0.99%)}	_~	_1.47s	_1.50s	_{p=0.557 n=6}
_{Check Time}	_{24.30s (± 0.35%)}	_{24.31s (± 0.77%)}	_~	_24.12s	_24.67s	_{p=0.575 n=6}
_{Emit Time}	_0.00s	_0.00s	_~	_~	_~	_{p=1.000 n=6}
_{Total Time}	_{30.03s (± 0.27%)}	_{30.03s (± 0.60%)}	_~	_29.86s	_30.37s	_{p=0.630 n=6}

System info unknown

Hosts

node (v18.15.0, x64)

Scenarios

Compiler-Unions - node (v18.15.0, x64)
angular-1 - node (v18.15.0, x64)
mui-docs - node (v18.15.0, x64)
self-build-src - node (v18.15.0, x64)
self-build-src-public-api - node (v18.15.0, x64)
self-compiler - node (v18.15.0, x64)
ts-pre-modules - node (v18.15.0, x64)
vscode - node (v18.15.0, x64)
webpack - node (v18.15.0, x64)
xstate-main - node (v18.15.0, x64)

_Benchmark	_Name	_Iterations
_Current	_pr	₆
_Baseline	_baseline	₆

Developer Information:

Download Benchmarks

typescript-bot · 2025-02-04T21:57:53Z

@RyanCavanaugh Here are the results of running the top 400 repos with tsc comparing main and refs/pull/61079/merge:

Something interesting changed - please have a look.

Details

microsoft/vscode

5 of 55 projects failed to build with the old tsc and were ignored

src/tsconfig.tsec.json

error TS2532: Object is possibly 'undefined'.
- src/vs/editor/common/services/findSectionHeaders.ts#L99
- src/vs/editor/common/services/findSectionHeaders.ts#L100

src/tsconfig.monaco.json

error TS2532: Object is possibly 'undefined'.
- src/vs/editor/common/services/findSectionHeaders.ts#L99
- src/vs/editor/common/services/findSectionHeaders.ts#L100

Fix RegExpIndicesArray by adding undefined to type definition

79b8d92

Fix microsoft#61078

typescript-bot added the For Uncommitted Bug PR for untriaged, rejected, closed or missing bug label Jan 30, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix RegExpIndicesArray by adding undefined to type definition #61079

Fix RegExpIndicesArray by adding undefined to type definition #61079

stefnotch commented Jan 29, 2025 •

edited

Loading

RyanCavanaugh commented Feb 4, 2025

typescript-bot commented Feb 4, 2025 •

edited

Loading

typescript-bot commented Feb 4, 2025

typescript-bot commented Feb 4, 2025

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

typescript-bot commented Feb 4, 2025

tsc

typescript-bot commented Feb 4, 2025

microsoft/vscode

src/tsconfig.tsec.json

src/tsconfig.monaco.json

Fix RegExpIndicesArray by adding undefined to type definition #61079

Are you sure you want to change the base?

Fix RegExpIndicesArray by adding undefined to type definition #61079

Conversation

stefnotch commented Jan 29, 2025 • edited Loading

RyanCavanaugh commented Feb 4, 2025

typescript-bot commented Feb 4, 2025 • edited Loading

typescript-bot commented Feb 4, 2025

typescript-bot commented Feb 4, 2025

azure-sdk

/mnt/ts_downloads/_/m/azure-sdk/build.sh

typescript-bot commented Feb 4, 2025

tsc

typescript-bot commented Feb 4, 2025

microsoft/vscode

src/tsconfig.tsec.json

src/tsconfig.monaco.json

stefnotch commented Jan 29, 2025 •

edited

Loading

typescript-bot commented Feb 4, 2025 •

edited

Loading