Just add a trailing call to visitNode instead of creating a new array when collecting outlining spans
#61987
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typescript-bot
added
Author: Team
For Uncommitted Bug
DanielRosenwasser
changed the title
visitNode instead of creating a new array.visitNode instead of creating a new array when collecting outlining spans
There was a problem hiding this comment.
Pull Request Overview
This PR refactors how the EOF token is included in outlining by removing the array spread and calling visitNode directly for the EOF token.
- Changed
statementsto use onlysourceFile.statementsand removed the array creation. - Added a standalone
visitNode(sourceFile.endOfFileToken)call after the main loop. - Updated comments to reflect the new approach.
Comments suppressed due to low confidence (1)
src/services/outliningElementsCollector.ts:89
- Consider adding a dedicated test (e.g., a fourslash or compiler test) to verify that comments at the end of the file are correctly captured by the new EOF token visit.
// Visit the EOF Token so that comments which aren't attached to statements are included.
navya9singh
approved these changes
Jul 2, 2025
DanielRosenwasser
deleted the
noUnnecessaryIntermediateArrayForOutliningSpans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.