Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding noscript placeholders #539

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Adding noscript placeholders #539

merged 1 commit into from
Feb 26, 2024

Conversation

ender336
Copy link
Contributor

Some css relies on specific number of children or position of children within a DOM tree. Adding noscript tags into our visualized DOM to maintain correctness.

Copy link
Member

@toby-walker toby-walker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ender336 ender336 merged commit 9fc2cd3 into master Feb 26, 2024
3 checks passed
@ender336 ender336 deleted the samart/noscriptPlaceholder branch February 26, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants