-
Notifications
You must be signed in to change notification settings - Fork 243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Empty parameter visibility and visibility string deprecation #6088
base: main
Are you sure you want to change the base?
[core] Empty parameter visibility and visibility string deprecation #6088
Conversation
…explicitly testing for legacy functionality
❌ There is undocummented changes. Run The following packages have changes but are not documented.
The following packages have already been documented:
Show changes
|
You can try these changes here
|
- "@typespec/compiler" | ||
--- | ||
|
||
Deprecate use of string-based visibility modifiers using warnings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add some diff code block to show how to migrate
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I think I'm also going to add a codefix if all the strings in the args are lifecycle strings.
parameterVisibility
/returnTypeVisibility
with no arguments.LegacyParameterVisibility
HTTP flag.visibility-legacy
and will be converted to errors in 1.0-rc.PatchOptions
/getPatchOptions
which now controlsVisibility.Patch
.WIP:
PatchOptions
.