XmlPayload added

[filisko]

What do you think? 😅

This following code is just to convert the SimpleXML object to an array or a simple object (stdClass), this way it's more consistent to JSON payload and also if at some point we want to change the XML parser, it won't have any effect because we will still return simple arrays and objects (stdClass).

$json = json_encode($xml);
$array = json_decode($json, $this->associative);

[oscarotero]

Sorry but I'm not convinced about this. XMLPayload should parse a XML code and generate a SimpleXMLElement object, but not an array. The array could be generated in a different middleware, but out of the scope of this, because there's many different ways to convert a xml structure into a json, or the user may not want an array.

If you remove the xml to array conversion, I'd merge this.

Thanks!

[filisko]

Great :) I didn't ask you 'What do you think?' by coincidence haha, I was with some doubts too.

What do you think about the tests? Should I create a separated method to test the empty case (it throws an exception)?

[oscarotero]

The test is fine. Not sure if empty payload should return an excepcion, maybe just return null?

[oscarotero]

Thanks! 👍

[filisko]

Thanks to you for sharing first!
I think you can update the repository description now "PSR-15 middleware to parse the body of the request with support for json, csv, url-encode and xml" :)