fix: cache schema globally (hamba#293)

mihaitodor · Aug 21, 2023 · 4c8b624 · 4c8b624
1 parent 0781a60
commit 4c8b624
Show file tree

Hide file tree

Showing 3 changed files with 35 additions and 68 deletions.
diff --git a/cmd/avrogen/testdata/golden_encoders.go b/cmd/avrogen/testdata/golden_encoders.go
diff --git a/gen/gen.go b/gen/gen.go
@@ -61,25 +61,22 @@ import (
 )
 {{ end }}
 
+
+
 {{- range .Typedefs }}
 // {{ .Name }} is a generated struct.
 type {{ .Name }} struct {
 	{{- range .Fields }}
 		{{ .Name }} {{ .Type }} {{ .Tag }}
 	{{- end }}
-{{- if $encoders }}
-
-    schema avro.Schema
-{{- end }}
 }
 
 {{- if $encoders }}
+var schema{{ .Name }} = avro.MustParse(` + "`{{ .Schema }}`" + `)
+
 // Schema returns the schema for {{ .Name }}.
 func (o *{{ .Name }}) Schema() avro.Schema {
-  if o.schema == nil {
-    o.schema = avro.MustParse(` + "`{{ .Schema }}`" + `)
-  }
-  return o.schema
+  return schema{{ .Name }}
 }
 
 // Unmarshal decodes b into the receiver.

diff --git a/gen/testdata/golden_encoders.go b/gen/testdata/golden_encoders.go