-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add GitHub actions #9
Conversation
Reviewer's Guide by SourceryThis pull request adds GitHub Actions for CI/CD, updates the README with badges, modifies the unit test setup, and makes some minor changes to the codebase. The main focus is on implementing automated workflows for code quality checks, building, testing, and deployment. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @mihamieat - I've reviewed your changes and found some issues that need to be addressed.
Blocking issues:
- Hardcoded token found in README badge URL. (link)
Overall Comments:
- Please review the removal of MongoDB credentials in docker-compose.test.yaml. Ensure this change doesn't introduce any security vulnerabilities or break the test environment setup.
- Great job on implementing CI/CD and test coverage reporting. Consider reviewing the deployment workflow to ensure it includes all necessary steps for a secure and complete deployment process.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🔴 Security: 1 blocking issue, 1 other issue
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 3 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
469af5f
to
126620a
Compare
126620a
to
d95b96f
Compare
Closes #3 |
Summary by Sourcery
Add GitHub Actions for CI/CD, including workflows for code quality, building, testing, and deployment. Update the README with badges and additional instructions for Docker and unit testing. Upgrade the Black formatter version in the pre-commit configuration.
New Features:
Enhancements:
CI:
Deployment:
Documentation: