[wip] export maps and builtins #2
Conversation
mikeal
changed the title
mikeal
changed the title
| file &File | ||
| deps PackageMap | ||
| builtins optional [String] | ||
| } | ||
| type Exports struct { |
There was a problem hiding this comment.
exports can also be an object with properties (like a dot, for main) or a string, or an array of those.
There was a problem hiding this comment.
https://npmcdn.com/[email protected]/package.json may be helpful as a valid example
There was a problem hiding this comment.
this data structure is per-file (or per module in native ESM terms), so if there are exports for multiple endpoints they would get multiple data-structures, each with their own Exports struct.
There was a problem hiding this comment.
to be clear, this export map swaps out the file returned for each native ESM module. if a package.json declares multiple endpoints then each of those files will get it’s own export map in order to branch on a file-by-file basis.
There was a problem hiding this comment.
Gotcha, sorry for my misunderstanding.
There could, however, be multiple potential files for each specifier when "exports" is used.
There was a problem hiding this comment.
@ljharb is that due to the fallback logic?
There was a problem hiding this comment.
The fallback logic, and the upcoming conditional exports, will mean that different node versions and different environments and different module systems could all point to different files. They'll all be statically determinable, but there'll be 0, 1, or N files resulting from that.
There was a problem hiding this comment.
hrm... i’m fine with holding off on supporting the full spectrum since there’s other limitations that reg already imposes on what you can and cannot do.
Starting to work through what it would take to support export maps since I think I’m going to need them for statically linking the standard library.
@MylesBorins curious if you have any thoughts. In particular, I’m wondering if there is every a case where I can’t locate a default file for export. Please @ anyone you think has thoughts on this.