Fix for notification NPE on unknown sender.

mikehotel · Feb 21, 2013 · 5bf5b40 · 5bf5b40
1 parent f73adfc
commit 5bf5b40
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/src/org/thoughtcrime/securesms/notifications/MessageNotifier.java b/src/org/thoughtcrime/securesms/notifications/MessageNotifier.java
@@ -292,7 +292,7 @@ private static CharSequence getBody(Context context, MasterSecret masterSecret,
   private static Recipients getSmsRecipient(Context context, Cursor cursor)
       throws RecipientFormattingException
   {
-    String address        = cursor.getString(cursor.getColumnIndexOrThrow(SmsDatabase.ADDRESS));
+    String address = cursor.getString(cursor.getColumnIndexOrThrow(SmsDatabase.ADDRESS));
     return RecipientFactory.getRecipientsFromString(context, address, false);
   }
 
@@ -305,19 +305,27 @@ private static Recipients getMmsRecipient(Context context, Cursor cursor)
   }
 
   private static Recipients getRecipients(Context context, Cursor cursor) {
-    String type = cursor.getString(cursor.getColumnIndexOrThrow(MmsSmsDatabase.TRANSPORT));
+    String type           = cursor.getString(cursor.getColumnIndexOrThrow(MmsSmsDatabase.TRANSPORT));
+    Recipients recipients = null;
 
     try {
       if (type.equals("sms")) {
-        return getSmsRecipient(context, cursor);
+        recipients = getSmsRecipient(context, cursor);
       } else {
-        return getMmsRecipient(context, cursor);
+        recipients = getMmsRecipient(context, cursor);
       }
     } catch (RecipientFormattingException e) {
       Log.w("MessageNotifier", e);
       return new Recipients(new Recipient("Unknown", "Unknown", null,
                             ContactPhotoFactory.getDefaultContactPhoto(context)));
     }
+
+    if (recipients == null || recipients.isEmpty()) {
+      recipients = new Recipients(new Recipient("Unknown", "Unknown", null,
+                                                ContactPhotoFactory.getDefaultContactPhoto(context)));
+    }
+
+    return recipients;
   }
 
   private static void setNotificationAlarms(Context context,