Skip to content

Commit

Permalink
DolphinQt: Make conversion error messages actually show up
Browse files Browse the repository at this point in the history
I don't know why QErrorMessage doesn't work, but ModalMessageBox
works, so let's use ModalMessageBox.
  • Loading branch information
JosJuice committed Jun 16, 2020
1 parent 2b25e1d commit 20a3119
Showing 1 changed file with 4 additions and 3 deletions.
7 changes: 4 additions & 3 deletions Source/Core/DolphinQt/ConvertDialog.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@

#include <QCheckBox>
#include <QComboBox>
#include <QErrorMessage>
#include <QFileDialog>
#include <QGridLayout>
#include <QGroupBox>
Expand Down Expand Up @@ -329,7 +328,8 @@ void ConvertDialog::Convert()

if (!blob_reader)
{
QErrorMessage(this).showMessage(
ModalMessageBox::critical(
this, tr("Error"),
tr("Failed to open the input file \"%1\".").arg(QString::fromStdString(original_path)));
return;
}
Expand Down Expand Up @@ -362,7 +362,8 @@ void ConvertDialog::Convert()
progress_dialog.GetRaw()->exec();
if (!good.get())
{
QErrorMessage(this).showMessage(tr("Dolphin failed to complete the requested action."));
ModalMessageBox::critical(this, tr("Error"),
tr("Dolphin failed to complete the requested action."));
return;
}
}
Expand Down

0 comments on commit 20a3119

Please sign in to comment.