Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Remove QueryCoord's scheduling of L0 segments #39552

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

weiliu1031
Copy link
Contributor

issue: #39551
This PR remove querycoord's scheduling of l0 segments:

  • only load l0 segment when watch channel
  • only release l0 segment when release channel or sync data distribution

@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Jan 23, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 23, 2025
Copy link
Contributor

mergify bot commented Jan 23, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.40%. Comparing base (f0b7446) to head (96156dc).
Report is 1 commits behind head on master.

❌ Your project check has failed because the head coverage (69.40%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (f0b7446) and HEAD (96156dc). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (f0b7446) HEAD (96156dc)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39552       +/-   ##
===========================================
- Coverage   80.10%   69.40%   -10.70%     
===========================================
  Files        1465      302     -1163     
  Lines      203148    27065   -176083     
===========================================
- Hits       162733    18785   -143948     
+ Misses      34602     8280    -26322     
+ Partials     5813        0     -5813     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.40% <ø> (ø)
Go ∅ <ø> (∅)

see 1163 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

rerun ut

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Feb 5, 2025

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/internal-api dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants