Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: refine variable-length-type memory usage(#38736) #39578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrPresent-Han
Copy link
Contributor

related: #38736

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 24, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign tedxu after the PR has been reviewed.
You can assign the PR to them by writing /assign @tedxu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 24, 2025
Copy link
Contributor

mergify bot commented Jan 24, 2025

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the enhance-array-new-review-v1 branch from 46e8842 to 4c4c0b4 Compare January 24, 2025 07:37
@MrPresent-Han MrPresent-Han force-pushed the enhance-array-new-review-v1 branch from 4c4c0b4 to 058527d Compare January 24, 2025 07:41
@sre-ci-robot sre-ci-robot added size/XL Denotes a PR that changes 500-999 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels Jan 24, 2025
Copy link
Contributor

mergify bot commented Jan 24, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 24, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 24, 2025

Codecov Report

Attention: Patch coverage is 60.00000% with 60 lines in your changes missing coverage. Please review.

Project coverage is 69.39%. Comparing base (6d8441a) to head (058527d).
Report is 8 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/common/ChunkWriter.cpp 61.76% 13 Missing ⚠️
internal/core/src/common/Chunk.h 78.04% 9 Missing ⚠️
internal/core/src/mmap/ChunkedColumn.h 22.22% 7 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.22% 7 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 12.50% 7 Missing ⚠️
internal/core/src/common/Chunk.cpp 70.58% 5 Missing ⚠️
internal/core/src/mmap/Column.h 20.00% 4 Missing ⚠️
internal/core/src/segcore/SegmentInterface.h 73.33% 4 Missing ⚠️
internal/core/src/segcore/SegmentGrowingImpl.cpp 0.00% 3 Missing ⚠️
internal/core/src/common/ChunkWriter.h 87.50% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (60.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (6d8441a) and HEAD (058527d). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (6d8441a) HEAD (058527d)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39578       +/-   ##
===========================================
- Coverage   81.00%   69.39%   -11.62%     
===========================================
  Files        1423      300     -1123     
  Lines      200194    27032   -173162     
===========================================
- Hits       162168    18758   -143410     
+ Misses      32278     8274    -24004     
+ Partials     5748        0     -5748     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 69.39% <60.00%> (-0.18%) ⬇️
Go ∅ <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/common/ChunkTarget.h 100.00% <ø> (ø)
internal/core/src/common/Common.h 0.00% <ø> (-100.00%) ⬇️
internal/core/src/exec/expression/Expr.h 69.28% <ø> (ø)
internal/core/src/exec/expression/TermExpr.cpp 85.04% <ø> (ø)
...ternal/core/src/segcore/ChunkedSegmentSealedImpl.h 28.57% <ø> (ø)
internal/core/src/segcore/SegmentGrowingImpl.h 69.04% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.h 57.14% <ø> (ø)
internal/core/src/storage/PayloadReader.cpp 100.00% <100.00%> (ø)
internal/core/src/common/ChunkWriter.h 59.25% <87.50%> (+3.09%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.cpp 81.88% <0.00%> (-0.44%) ⬇️
... and 8 more

... and 1124 files with indirect coverage changes

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e
rerun go-sdk
rerun ut

@MrPresent-Han
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Jan 26, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants