-
-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use separator character for boundary quit logic and prefix sort #120
Conversation
Very good, I will try this in the next few days. So if we bind SPC to corfu-insert-separator we get the current quit-at-boundary behavior? If we bind M-SPC instead we get the enhanced behavior? I guess we could bind M-SPC by default. |
I gave it a quick review. This looks very good, nice and simple. There are only a few minor details. Then there is the question if we want to support disabling the separator character completely - by setting it to ?\0 or nil. |
I suppose that's right. Or, if you (or the user) binds nothing at all to
I tried to think of a real usage case for disabling the behavior of the separator. Unless you invoke
I don't know if 2 is occurring anywhere in the wild for the default space separator. But allowing this to be Also, regarding the binding, should we bind it ourselves or let the user pick? I've also tried |
I just want the ability to disable this out of principle, but I agree that having a separator like space (also having it enabled by default) is benign |
We should add the binding M-SPC by default. It is easy to unbind this in a user configuration. We also preconfigure separator=SPC. |
This looks good, thanks! |
This reverts commit fe491a5.
fe491a5
to
2c5967d
Compare
Implement a component separator character and associated insertion command (
corfu-insert-separator-char
), used to inhibit quitting at completion boundaries (see #119). This character is also removed from prefix sorting, superseding #118.This is useful for multi-component completion styles such as orderless. A convenient key binding for
corfu-insert-separator-char
such asM-SPC
can be used to insert the initial completion component separator.Obsoletes
corfu-quit-at-boundary
(for v0.19). Setup documentation is provided.