Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor refactoring of internal/ui/static/js/touch_handler.js #3059

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jvoisin
Copy link
Collaborator

@jvoisin jvoisin commented Jan 4, 2025

  • Mark a method as static
  • use Math.sqrt instead of Math.pow(…, 0.5)
  • Use Math.sign instead of a condition on the sign
  • Inline some used-once variables
  • Reduce the scope of some variables

- Mark a method as `static`
- use `Math.sqrt` instead of `Math.pow(…, 0.5)`
- Use `Math.sign` instead of a condition on the sign
- Inline some used-once variables
- Reduce the scope of some variables
@jvoisin jvoisin force-pushed the refactor_touchannder branch from 5a38700 to 144969b Compare January 4, 2025 21:41
Copy link
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like swipe gestures are broken with these changes:

Uncaught TypeError: this.findElement is not a function
    at ee.onItemTouchStart (app.919c0e6bcf51a26676c22f7b3e73946f291f50db9c333c8a2d31e934c94723d1.js:2:1516)

and:

app.919c0e6bcf51a266…31e934c94723d1.js:2 Uncaught TypeError: Cannot read properties of null (reading 'style')
    at ee.onItemTouchMove (app.919c0e6bcf51a266…4c94723d1.js:2:1910)

Browser console logs:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants