Golf a bit internal/ui/static/js/modal_handler.js #3060
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ES11 was released 5 years ago, and every browser supports optional chaining since at least 2016 |
Fair enough. In that case, the linter and minifier configs can be changed to use ES11. |
jvoisin
force-pushed
the
golf_modal
branch
3 times, most recently
from
09bddc2 to
f65c9c8
Compare
jvoisin
force-pushed
the
golf_modal
branch
3 times, most recently
from
1d31778 to
1525b52
Compare
- Inline two useless functions - Use the modern `.at` method instead of `[focusableElements.length - 1], as it's supported on all browsers since 2016: https://caniuse.com/mdn-javascript_builtins_string_at
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.atmethod instead of[focusableElements.length - 1], as it's supported on all browsers since 2016: https://caniuse.com/mdn-javascript_builtins_string_at