Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify a bit internal/ui/static/js/keyboard_handler.js #3061

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Simplify a bit internal/ui/static/js/keyboard_handler.js #3061

wants to merge 1 commit into from
+9 −16

Conversation

jvoisin
Copy link
Collaborator

@jvoisin jvoisin commented Jan 4, 2025

  • Mark two methods as static
  • Use a switch-case construct instead of an Object and a loop.

@jvoisin
Simplify a bit internal/ui/static/js/keyboard_handler.js
c03e4d7 
- Mark two methods as static
- Use a `switch-case` construct instead of an Object and a loop.
fguillot
fguillot requested changes Jan 12, 2025
View reviewed changes
Copy link
Member

@fguillot fguillot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm getting this error Uncaught TypeError: this.getKey is not a function in the browser console which prevent the keyboard shortcuts to work:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fguillot fguillot fguillot requested changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jvoisin @fguillot