Chore: Add consistent import type (pixijs#8434)

.eslintrc.json

@@ -18,6 +18,7 @@
         }
     },
     "rules": {
+        "@typescript-eslint/consistent-type-imports": [1, { "disallowTypeAnnotations": false }],
         "@typescript-eslint/no-parameter-properties": 1,
         "@typescript-eslint/type-annotation-spacing": 1,
         "jsdoc/multiline-blocks": [

packages/accessibility/src/AccessibilityManager.ts

@@ -4,7 +4,8 @@ import { accessibleTarget } from './accessibleTarget';
 
 import type { Rectangle } from '@pixi/math';
 import type { Container } from '@pixi/display';
-import { Renderer, AbstractRenderer, ExtensionMetadata, ExtensionType } from '@pixi/core';
+import type { Renderer, AbstractRenderer, ExtensionMetadata } from '@pixi/core';
+import { ExtensionType } from '@pixi/core';
 import type { IAccessibleHTMLElement } from './accessibleTarget';
 
 // add some extra variables to the container..

packages/app/src/ResizePlugin.ts

@@ -1,5 +1,6 @@
 import type { CanvasRenderer } from '@pixi/canvas-renderer';
-import { ExtensionMetadata, ExtensionType, Renderer } from '@pixi/core';
+import type { ExtensionMetadata, Renderer } from '@pixi/core';
+import { ExtensionType } from '@pixi/core';
 import type { IApplicationOptions } from './Application';
 
 /**

packages/basis/src/BasisLoader.ts

@@ -1,20 +1,22 @@
 import { TYPES, MIPMAP_MODES, ALPHA_MODES, FORMATS } from '@pixi/constants';
-import { BaseTexture, BufferResource, ExtensionMetadata, ExtensionType, Texture } from '@pixi/core';
-import { CompressedTextureResource, INTERNAL_FORMATS } from '@pixi/compressed-textures';
+import type { ExtensionMetadata } from '@pixi/core';
+import { BaseTexture, BufferResource, ExtensionType, Texture } from '@pixi/core';
+import { CompressedTextureResource } from '@pixi/compressed-textures';
+import type {
+    BasisTextureExtensions,
+    BasisBinding } from './Basis';
 import {
     BASIS_FORMATS,
     BASIS_FORMAT_TO_INTERNAL_FORMAT,
     INTERNAL_FORMAT_TO_BASIS_FORMAT,
     BASIS_FORMATS_ALPHA,
-    BasisTextureExtensions,
-    BasisBinding,
     BASIS_FORMAT_TO_TYPE,
 } from './Basis';
 import { TranscoderWorker } from './TranscoderWorker';
 import { LoaderResource } from '@pixi/loaders';
 
 import type { IResourceMetadata } from '@pixi/loaders';
-import type { CompressedLevelBuffer } from '@pixi/compressed-textures';
+import type { CompressedLevelBuffer, INTERNAL_FORMATS } from '@pixi/compressed-textures';
 
 type TranscodedResourcesArray = (Array<CompressedTextureResource> | Array<BufferResource>) & {
     basisFormat: BASIS_FORMATS

packages/basis/src/TranscoderWorker.ts

@@ -1,6 +1,7 @@
 import { Runner } from '@pixi/runner';
-import { BASIS_FORMATS } from './Basis';
-import { ITranscodeResponse, TranscoderWorkerWrapper } from './TranscoderWorkerWrapper';
+import type { BASIS_FORMATS } from './Basis';
+import type { ITranscodeResponse } from './TranscoderWorkerWrapper';
+import { TranscoderWorkerWrapper } from './TranscoderWorkerWrapper';
 
 /**
  * Worker class for transcoding *.basis files in background threads.

packages/canvas-extract/src/CanvasExtract.ts

@@ -1,9 +1,9 @@
-import { ExtensionMetadata, ExtensionType, RenderTexture } from '@pixi/core';
+import { ExtensionType, RenderTexture } from '@pixi/core';
 import { CanvasRenderTarget } from '@pixi/utils';
 import { Rectangle } from '@pixi/math';
-import { CanvasRenderer } from '@pixi/canvas-renderer';
+import type { CanvasRenderer } from '@pixi/canvas-renderer';
 import type { DisplayObject } from '@pixi/display';
-import type { BaseRenderTexture } from '@pixi/core';
+import type { BaseRenderTexture, ExtensionMetadata } from '@pixi/core';
 
 const TEMP_RECT = new Rectangle();
 

packages/canvas-graphics/src/CanvasGraphicsRenderer.ts

@@ -1,7 +1,8 @@
-import { ExtensionMetadata, ExtensionType, Texture } from '@pixi/core';
+import type { ExtensionMetadata } from '@pixi/core';
+import { ExtensionType, Texture } from '@pixi/core';
 import { SHAPES, Matrix } from '@pixi/math';
-import { canvasUtils, CrossPlatformCanvasRenderingContext2D } from '@pixi/canvas-renderer';
-import type { CanvasRenderer } from '@pixi/canvas-renderer';
+import { canvasUtils } from '@pixi/canvas-renderer';
+import type { CanvasRenderer, CrossPlatformCanvasRenderingContext2D } from '@pixi/canvas-renderer';
 import type { FillStyle, Graphics, GraphicsData, LineStyle } from '@pixi/graphics';
 import type { Circle, Ellipse, Polygon, Rectangle, RoundedRectangle } from '@pixi/math';
 import { PolygonUtils } from './utils/PolygonUtils';

packages/canvas-mesh/src/CanvasMeshRenderer.ts

@@ -1,4 +1,5 @@
-import { ExtensionMetadata, ExtensionType, Texture } from '@pixi/core';
+import type { ExtensionMetadata } from '@pixi/core';
+import { ExtensionType, Texture } from '@pixi/core';
 import { DRAW_MODES } from '@pixi/constants';
 import { canvasUtils } from '@pixi/canvas-renderer';
 

packages/canvas-prepare/src/CanvasPrepare.ts

@@ -1,7 +1,7 @@
-import { BaseTexture, ExtensionMetadata, ExtensionType } from '@pixi/core';
+import { BaseTexture, ExtensionType } from '@pixi/core';
 import { BasePrepare } from '@pixi/prepare';
 
-import type { AbstractRenderer } from '@pixi/core';
+import type { AbstractRenderer, ExtensionMetadata } from '@pixi/core';
 import type { CanvasRenderer } from '@pixi/canvas-renderer';
 import type { IDisplayObjectExtended } from '@pixi/prepare';
 

packages/canvas-renderer/src/utils/CanvasMaskManager.ts

@@ -1,4 +1,5 @@
-import { Polygon, SHAPES } from '@pixi/math';
+import type { Polygon } from '@pixi/math';
+import { SHAPES } from '@pixi/math';
 
 import type { CanvasRenderer } from '../CanvasRenderer';
 import type { Graphics } from '@pixi/graphics';

packages/canvas-sprite/src/CanvasSpriteRenderer.ts

@@ -3,7 +3,8 @@ import { Matrix, groupD8 } from '@pixi/math';
 import { canvasUtils } from '@pixi/canvas-renderer';
 import type { CanvasRenderer } from '@pixi/canvas-renderer';
 import type { Sprite } from '@pixi/sprite';
-import { ExtensionMetadata, ExtensionType } from '@pixi/core';
+import type { ExtensionMetadata } from '@pixi/core';
+import { ExtensionType } from '@pixi/core';
 
 const canvasRenderWorldTransform = new Matrix();
 

packages/compressed-textures/src/loaders/CompressedTextureLoader.ts

@@ -3,7 +3,8 @@ import { url } from '@pixi/utils';
 
 import type { Loader } from '@pixi/loaders';
 import type { INTERNAL_FORMATS } from '../const';
-import { ExtensionMetadata, ExtensionType } from '@pixi/core';
+import type { ExtensionMetadata } from '@pixi/core';
+import { ExtensionType } from '@pixi/core';
 
 /**
  * Schema for compressed-texture manifests

packages/compressed-textures/src/loaders/DDSLoader.ts

@@ -2,7 +2,8 @@ import { CompressedTextureResource } from '../resources';
 import { INTERNAL_FORMATS, INTERNAL_FORMAT_TO_BYTES_PER_PIXEL } from '../const';
 import { LoaderResource } from '@pixi/loaders';
 import { registerCompressedTextures } from './registerCompressedTextures';
-import { ExtensionMetadata, ExtensionType } from '@pixi/core';
+import type { ExtensionMetadata } from '@pixi/core';
+import { ExtensionType } from '@pixi/core';
 
 // Set DDS files to be loaded as an ArrayBuffer
 LoaderResource.setExtensionXhrType('dds', LoaderResource.XHR_RESPONSE_TYPE.BUFFER);

packages/compressed-textures/src/loaders/KTXLoader.ts

@@ -1,6 +1,8 @@
 import { ALPHA_MODES, FORMATS, MIPMAP_MODES, TYPES } from '@pixi/constants';
-import { BaseTexture, BufferResource, ExtensionMetadata, ExtensionType, Texture } from '@pixi/core';
-import { CompressedLevelBuffer, CompressedTextureResource } from '../resources/CompressedTextureResource';
+import type { ExtensionMetadata } from '@pixi/core';
+import { BaseTexture, BufferResource, ExtensionType, Texture } from '@pixi/core';
+import type { CompressedLevelBuffer } from '../resources/CompressedTextureResource';
+import { CompressedTextureResource } from '../resources/CompressedTextureResource';
 import { LoaderResource } from '@pixi/loaders';
 import { INTERNAL_FORMAT_TO_BYTES_PER_PIXEL } from '../const';
 import { registerCompressedTextures } from './registerCompressedTextures';

packages/compressed-textures/src/resources/BlobResource.ts

@@ -1,4 +1,5 @@
-import { Resource, ViewableBuffer, BufferResource } from '@pixi/core';
+import type { Resource } from '@pixi/core';
+import { ViewableBuffer, BufferResource } from '@pixi/core';
 
 interface IBlobOptions
 {

packages/compressed-textures/src/resources/CompressedTextureResource.ts

@@ -1,6 +1,6 @@
 import { BlobResource } from './BlobResource';
 import { INTERNAL_FORMAT_TO_BYTES_PER_PIXEL } from '../const';
-import { Renderer, BaseTexture, GLTexture } from '@pixi/core';
+import type { Renderer, BaseTexture, GLTexture } from '@pixi/core';
 
 import type { INTERNAL_FORMATS } from '../const';
 

packages/core/src/AbstractRenderer.ts

@@ -1,10 +1,10 @@
 import { hex2string, hex2rgb, EventEmitter, deprecation } from '@pixi/utils';
 import { Matrix, Rectangle } from '@pixi/math';
-import { MSAA_QUALITY, RENDERER_TYPE } from '@pixi/constants';
+import { RENDERER_TYPE } from '@pixi/constants';
 import { settings } from '@pixi/settings';
 import { RenderTexture } from './renderTexture/RenderTexture';
 
-import type { SCALE_MODES } from '@pixi/constants';
+import type { SCALE_MODES, MSAA_QUALITY } from '@pixi/constants';
 import type { ISystemConstructor } from './ISystem';
 import type { IRenderingContext } from './IRenderingContext';
 import type { IRenderableContainer, IRenderableObject } from './IRenderableObject';

packages/core/src/Renderer.ts

@@ -16,7 +16,8 @@ import { BatchSystem } from './batch/BatchSystem';
 import { TextureGCSystem } from './textures/TextureGCSystem';
 import { MSAA_QUALITY, RENDERER_TYPE } from '@pixi/constants';
 import { UniformGroup } from './shader/UniformGroup';
-import { Matrix, Rectangle } from '@pixi/math';
+import type { Rectangle } from '@pixi/math';
+import { Matrix } from '@pixi/math';
 import { Runner } from '@pixi/runner';
 import { BufferSystem } from './geometry/BufferSystem';
 import { RenderTexture } from './renderTexture/RenderTexture';

packages/core/src/batch/BatchPluginFactory.ts

@@ -6,7 +6,8 @@ import defaultVertex from './texture.vert';
 import defaultFragment from './texture.frag';
 
 import type { Renderer } from '../Renderer';
-import { ExtensionMetadata, ExtensionType } from '../extensions';
+import type { ExtensionMetadata } from '../extensions';
+import { ExtensionType } from '../extensions';
 
 export interface IBatchFactoryOptions
 {

packages/core/src/filters/Filter.ts

@@ -1,16 +1,15 @@
-import { Shader } from '../shader/Shader';
+import { settings } from '@pixi/settings';
 import { Program } from '../shader/Program';
+import { Shader } from '../shader/Shader';
 import { State } from '../state/State';
-import { settings } from '@pixi/settings';
-import { MSAA_QUALITY } from '@pixi/constants';
-import defaultVertex from './defaultFilter.vert';
 import defaultFragment from './defaultFilter.frag';
+import defaultVertex from './defaultFilter.vert';
 
+import type { MSAA_QUALITY, BLEND_MODES, CLEAR_MODES } from '@pixi/constants';
+import type { Dict } from '@pixi/utils';
 import type { RenderTexture } from '../renderTexture/RenderTexture';
-import type { FilterSystem } from './FilterSystem';
 import type { FilterState } from './FilterState';
-import type { BLEND_MODES, CLEAR_MODES } from '@pixi/constants';
-import type { Dict } from '@pixi/utils';
+import type { FilterSystem } from './FilterSystem';
 
 /**
  * A filter is a special shader that applies post-processing effects to an input texture and writes into an output

packages/core/src/filters/FilterState.ts

@@ -1,4 +1,5 @@
-import { Matrix, Rectangle } from '@pixi/math';
+import type { Matrix } from '@pixi/math';
+import { Rectangle } from '@pixi/math';
 import { MSAA_QUALITY } from '@pixi/constants';
 
 import type { Filter } from './Filter';

packages/core/src/filters/spriteMask/SpriteMaskFilter.ts

@@ -1,6 +1,7 @@
 import { Filter } from '../Filter';
-import { Matrix, Point } from '@pixi/math';
-import { CLEAR_MODES } from '@pixi/constants';
+import type { Point } from '@pixi/math';
+import { Matrix } from '@pixi/math';
+import type { CLEAR_MODES } from '@pixi/constants';
 import vertex from './spriteMaskFilter.vert';
 import fragment from './spriteMaskFilter.frag';
 import { TextureMatrix } from '../../textures/TextureMatrix';

packages/core/src/geometry/Geometry.ts

@@ -4,7 +4,8 @@ import { interleaveTypedArrays } from './utils/interleaveTypedArrays';
 import { getBufferType } from '@pixi/utils';
 import { Runner } from '@pixi/runner';
 
-import { BUFFER_TYPE, TYPES } from '@pixi/constants';
+import type { TYPES } from '@pixi/constants';
+import { BUFFER_TYPE } from '@pixi/constants';
 import type { IArrayBuffer } from './Buffer';
 import type { Dict } from '@pixi/utils';
 

packages/core/src/geometry/GeometrySystem.ts

@@ -1,4 +1,4 @@
-import { GLBuffer } from './GLBuffer';
+import type { GLBuffer } from './GLBuffer';
 import { ENV } from '@pixi/constants';
 import { settings } from '../settings';
 

packages/core/src/mask/MaskData.ts

@@ -1,6 +1,6 @@
 import { MASK_TYPES } from '@pixi/constants';
 import { settings } from '@pixi/settings';
-import { ISpriteMaskFilter } from '@pixi/core';
+import type { ISpriteMaskFilter } from '@pixi/core';
 
 import type { COLOR_MASK_BITS, MSAA_QUALITY } from '@pixi/constants';
 import type { Rectangle, Matrix } from '@pixi/math';

packages/core/src/renderTexture/RenderTextureSystem.ts

@@ -1,5 +1,5 @@
 import { Rectangle } from '@pixi/math';
-import { BUFFER_BITS } from '@pixi/constants';
+import type { BUFFER_BITS } from '@pixi/constants';
 
 import type { ISystem } from '../ISystem';
 import type { Renderer } from '../Renderer';

packages/core/src/shader/ShaderSystem.ts

@@ -1,4 +1,4 @@
-import { GLProgram } from './GLProgram';
+import type { GLProgram } from './GLProgram';
 import { generateUniformsSync, unsafeEvalSupported } from './utils';
 
 import type { ISystem } from '../ISystem';

packages/core/src/shader/utils/generateProgram.ts

@@ -1,4 +1,4 @@
-import { Program } from '../Program';
+import type { Program } from '../Program';
 import type { IRenderingContext } from '../../IRenderingContext';
 import type { IGLUniformData } from '../GLProgram';
 import { GLProgram } from '../GLProgram';

packages/core/src/shader/utils/generateUniformBufferSync.ts

@@ -1,7 +1,7 @@
 import type { Dict } from '@pixi/utils';
 import { mapSize } from '../utils';
-import { IUniformData } from '../Program';
-import { UniformGroup } from '../UniformGroup';
+import type { IUniformData } from '../Program';
+import type { UniformGroup } from '../UniformGroup';
 import { uniformParsers } from './uniformParsers';
 import type { Renderer } from '../../Renderer';
 import type { Buffer } from '../../geometry/Buffer';

packages/core/src/shader/utils/getAttributeData.ts

@@ -1,4 +1,4 @@
-import { IAttributeData } from '../Program';
+import type { IAttributeData } from '../Program';
 import { mapSize } from './mapSize';
 import { mapType } from './mapType';
 

packages/core/src/shader/utils/getUniformData.ts

@@ -1,4 +1,4 @@
-import { IUniformData } from '../Program';
+import type { IUniformData } from '../Program';
 import { defaultValue } from './defaultValue';
 import { mapType } from './mapType';
 

packages/core/src/textures/BaseTexture.ts

@@ -1,11 +1,11 @@
 import { BaseTextureCache, EventEmitter, isPow2, TextureCache, uid } from '@pixi/utils';
-import { FORMATS, SCALE_MODES, TARGETS, TYPES, ALPHA_MODES, MIPMAP_MODES, WRAP_MODES } from '@pixi/constants';
+import { FORMATS, SCALE_MODES, TARGETS, TYPES, ALPHA_MODES } from '@pixi/constants';
 import { Resource } from './resources/Resource';
 import { BufferResource } from './resources/BufferResource';
 import { autoDetectResource } from './resources/autoDetectResource';
 import { settings } from '@pixi/settings';
 
-import type { MSAA_QUALITY } from '@pixi/constants';
+import type { MSAA_QUALITY, MIPMAP_MODES, WRAP_MODES } from '@pixi/constants';
 import type { IAutoDetectOptions } from './resources/autoDetectResource';
 import type { GLTexture } from './GLTexture';
 

packages/core/src/textures/resources/AbstractMultiResource.ts

@@ -1,7 +1,8 @@
 import { Resource } from './Resource';
 import { BaseTexture } from '../BaseTexture';
-import { ISize } from '@pixi/math';
-import { autoDetectResource, IAutoDetectOptions } from './autoDetectResource';
+import type { ISize } from '@pixi/math';
+import type { IAutoDetectOptions } from './autoDetectResource';
+import { autoDetectResource } from './autoDetectResource';
 
 /**
  * Resource that can manage several resource (items) inside.

packages/core/src/textures/resources/ArrayResource.ts

@@ -1,6 +1,6 @@
 import { AbstractMultiResource } from './AbstractMultiResource';
 import { TARGETS } from '@pixi/constants';
-import { BaseTexture } from '../BaseTexture';
+import type { BaseTexture } from '../BaseTexture';
 
 import type { BaseImageResource } from './BaseImageResource';
 import type { Renderer } from '../../Renderer';

packages/core/src/textures/resources/autoDetectResource.ts

@@ -1,4 +1,4 @@
-import { Resource } from './Resource';
+import type { Resource } from './Resource';
 
 import type { IImageResourceOptions } from './ImageResource';
 import type { ISize } from '@pixi/math';

packages/core/test/ArrayResource.tests.ts

@@ -1,4 +1,5 @@
-import { ArrayResource, BaseTexture, ImageResource } from '@pixi/core';
+import type { BaseTexture } from '@pixi/core';
+import { ArrayResource, ImageResource } from '@pixi/core';
 import { join } from 'path';
 
 describe('ArrayResource', () =>

packages/core/test/BatchRenderer.tests.ts

@@ -1,4 +1,5 @@
-import { Renderer, BatchRenderer, CanvasResource, Texture, BaseTexture, IBatchableElement } from '@pixi/core';
+import type { IBatchableElement } from '@pixi/core';
+import { Renderer, BatchRenderer, CanvasResource, Texture, BaseTexture } from '@pixi/core';
 import { skipHello } from '@pixi/utils';
 import { BLEND_MODES } from '@pixi/constants';
 

packages/core/test/FilterSystem.tests.ts

@@ -1,5 +1,6 @@
 import { CLEAR_MODES } from '@pixi/constants';
-import { Filter, IFilterTarget, Renderer } from '@pixi/core';
+import type { IFilterTarget } from '@pixi/core';
+import { Filter, Renderer } from '@pixi/core';
 import { Matrix, Rectangle } from '@pixi/math';
 
 describe('FilterSystem', () =>

packages/core/test/ImageBitmapResource.tests.ts

@@ -1,4 +1,5 @@
-import { BaseTexture, ImageBitmapResource } from '@pixi/core';
+import type { BaseTexture } from '@pixi/core';
+import { ImageBitmapResource } from '@pixi/core';
 
 describe('ImageBitmapResource', () =>
 {

packages/core/test/MaskSystem.tests.ts

@@ -1,12 +1,13 @@
 import { MASK_TYPES, COLOR_MASK_BITS } from '@pixi/constants';
+import type {
+    IFilterTarget,
+    IMaskTarget } from '@pixi/core';
 import {
     BaseTexture,
     BatchRenderer,
     CanvasResource,
     extensions,
     Filter,
-    IFilterTarget,
-    IMaskTarget,
     MaskData,
     Renderer,
     RenderTexture,

packages/core/test/Renderer.tests.ts

@@ -1,4 +1,5 @@
-import { Renderer, Framebuffer, ObjectRenderer, extensions, BatchRenderer } from '@pixi/core';
+import type { ObjectRenderer } from '@pixi/core';
+import { Renderer, Framebuffer, extensions, BatchRenderer } from '@pixi/core';
 import { Graphics } from '@pixi/graphics';
 import { settings } from '@pixi/settings';
 import { ENV, MSAA_QUALITY } from '@pixi/constants';