⚡️ Speed up function _return_label
by 8%
#114
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄 8% (0.08x) speedup for
_return_label
inplotly/figure_factory/_facet_grid.py
⏱️ Runtime :
154 microseconds
→143 microseconds
(best of572
runs)📝 Explanation and details
Here’s an optimized version of your function.
Main changes.
type()
for direct, faster type checking instead ofisinstance()
(safe here, since faceting options are onlydict
,str
, or otherwise fallback)."{}: {}".format(..., ...)
with f-string, which is much faster.label
for each condition, reducing bytecode and eliminating branch (and some memory) overhead.All original comment structure is preserved as requested.
The function is now as fast as it can be (unless you need to switch to C extensions for this micro-benchmarked code).
Performance Notes:
isinstance()
saves 1–-2x the type check time for plain built-in types.str.format
by 30–100% for such simple string composition.Return value and logic are unchanged.
✅ Correctness verification report:
🌀 Generated Regression Tests Details
To edit these changes
git checkout codeflash/optimize-_return_label-mb2e38vc
and push.