Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code cleanup #14

Merged
merged 1 commit into from
May 30, 2014
Merged

code cleanup #14

merged 1 commit into from
May 30, 2014

Conversation

heckj
Copy link
Contributor

@heckj heckj commented May 29, 2014

  • wrapped node modules in immediately invoked function expression to
    preserve global vars and protect against accidental scope leak
  • added .jshintrc file
  • cleaned up code to match .jshintrc

@heckj
code cleanup
eb3fa08 
* wrapped node modules in immediately invoked function expression to
  preserve global vars and protect against accidental scope leak
* added .jshintrc file
* cleaned up code to match .jshintrc
@heckj
Copy link
Contributor Author

heckj commented May 29, 2014

I was looking for a rules-engine to use as a basis for an authorization policy engine I need to cobble for Node.js - started with your fork, wanted to see if you wanted things like this kind of cleanup. I'm also planning on adding some tests - would be happy to submit PR's for them if you're interested.

@munimkazia
Copy link
Collaborator

Hey, thanks a lot for this. I wish I had more time to clean this up myself.
You can start writing tests if you wish. It is something which I have been putting off for a long time myself, and I will start working on it this weekend if you haven't

munimkazia added a commit that referenced this pull request May 30, 2014
@munimkazia
Merge pull request #14 from heckj/cleanup
2e13972 
code cleanup
@munimkazia munimkazia merged commit 2e13972 into mithunsatheesh:master May 30, 2014
@munimkazia
Copy link
Collaborator

@mithunsatheesh I think this looks fine and we can publish it to npm, but run your own simple tests on it if you wish

@mithunsatheesh
Copy link
Owner

@heckj : awesome. thanks for the support. :)
@munimkazia : great :) . i have published the latest version on npm. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@heckj @munimkazia @mithunsatheesh