feature for conditions and consequences as string in input rules json #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ramanaveli2i There is one issue. The current implementation also allows an array of functions to be specified as the condition and/or the consequence. I believe this fix can break it. I think the checking needs to be more complete (check if array of functions, or array of strings. If not array, check if function or string). |
|
Oh ok got it and get back to you soon. |
mithunsatheesh
added a commit
that referenced
this pull request
Aug 23, 2013
feature for inputing condition and consequence Functions as string to rules json
|
@ramanaveli2i : merged! thanks for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Mithun,
I have added eval function to convert the string to function.
Please review the changes.