Makefile: add some new warnings to CXXFLAGS

Signed-off-by: Colin McCabe <[email protected]>
mitsu-ko · Apr 22, 2011 · 4b547cb · 4b547cb
1 parent 474be65
commit 4b547cb
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 9 deletions.
diff --git a/do_autogen.sh b/do_autogen.sh
@@ -8,7 +8,6 @@ do_autogen.sh: make a ceph build by running autogen, etc.
 -d <level>                       debug build
                                  level 0: no debug
                                  level 1: -g
-                                 level 2: -Wall
                                  level 3: -Wextra
                                  level 4: even more...
 -P                               profiling build
@@ -58,9 +57,6 @@ fi
 if [ "${debug_level}" -ge 1 ]; then
     CFLAGS="${CFLAGS} -g"
 fi
-if [ "${debug_level}" -ge 2 ]; then
-    CFLAGS="${CFLAGS} -Wall -Wvolatile-register-var"
-fi
 if [ "${debug_level}" -ge 3 ]; then
     CFLAGS="${CFLAGS} -Wextra \
 -Wno-missing-field-initializers -Wno-missing-declarations"

diff --git a/src/Makefile.am b/src/Makefile.am
@@ -478,16 +478,17 @@ CLEANFILES += \
 
 ##
 
+AM_COMMON_FLAGS = -Wall -D__CEPH__ -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_THREAD_SAFE -rdynamic \
+-Wtype-limits -Wignored-qualifiers
+
+AM_CFLAGS = $(AM_COMMON_FLAGS)
+AM_CXXFLAGS = $(AM_COMMON_FLAGS) -Wnon-virtual-dtor -Wno-invalid-offsetof
+AM_LDFLAGS = -Wl,--as-needed
 
-AM_CXXFLAGS = -Wall -D__CEPH__ -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_THREAD_SAFE -rdynamic -Wnon-virtual-dtor
 if USE_BOOST_SPIRIT_OLD_HDR
 AM_CXXFLAGS += -DUSE_BOOST_SPIRIT_OLD_HDR
 endif
 
-AM_CFLAGS = -Wall -D__CEPH__ -D_FILE_OFFSET_BITS=64 -D_REENTRANT -D_THREAD_SAFE -rdynamic
-AM_CXXFLAGS += -Wno-invalid-offsetof
-AM_LDFLAGS = -Wl,--as-needed
-
 if WITH_LIBATOMIC
 AM_LDFLAGS += -latomic_ops
 endif