Skip to content

Commit

Permalink
Merge pull request ceph#46943 from kalaspuffar/python39
Browse files Browse the repository at this point in the history
mgr/diskprediction_local: Support Python 3.9 for disk prediction module.

Reviewed-by: Kefu Chai <[email protected]>
  • Loading branch information
tchaikov authored Aug 23, 2022
2 parents a1d8b79 + 1969a63 commit ccff328
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion qa/tasks/mgr/test_module_selftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ def test_diskprediction_local(self):
self._load_module("selftest")
python_version = self.mgr_cluster.mon_manager.raw_cluster_cmd(
"mgr", "self-test", "python-version")
if tuple(int(v) for v in python_version.split('.')) >= (3, 8):
if tuple(int(v) for v in python_version.split('.')) == (3, 8):
# https://tracker.ceph.com/issues/45147
self.skipTest(f'python {python_version} not compatible with '
'diskprediction_local')
Expand Down
2 changes: 1 addition & 1 deletion src/common/options/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,7 @@ endif()
set(mgr_disabled_modules "")
if(WITH_MGR)
# https://tracker.ceph.com/issues/45147
if(Python3_VERSION VERSION_GREATER_EQUAL 3.8)
if(Python3_VERSION VERSION_EQUAL 3.8)
set(mgr_disabled_modules "diskprediction_local")
message(STATUS "mgr module disabled for ${Python3_VERSION}: ${mgr_disabled_modules}")
endif()
Expand Down

0 comments on commit ccff328

Please sign in to comment.