Osc in mixxx arm64 2.6 with TrackInfo (Title&Artist) -- Special OSCleton version #14181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a review, I just suggest you to do a small source reorganization. I see that in /src/osc/ip and /src/osc/osc , there is code from the library. This code should probably be relocated into /lib/osc you can do that with git (i don't know if you use the commandline or some graphical application) and it will keep the history. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Osc in mixxx arm64 2.6 with TrackInfo (Title&Artist) -- Special OSCleton version
Extra in this version : GetT# function to request TrackArtist & TrackTitle