fix: add HID error message upon failed open #14184
Open
+18
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daschuer
requested changes
Jan 19, 2025
|
|
||
| class LegacyControllerMapping; | ||
|
|
||
| namespace { | ||
| constexpr size_t kMaxHidErrorMessageSize = 512; | ||
| } |
There was a problem hiding this comment.
Suggested change
| } | |
| } // namespace |
| << m_deviceInfo.getVendorId() << m_deviceInfo.getProductId() | ||
| << m_deviceInfo.getSerialNumber(); | ||
| qCWarning(m_logBase) | ||
| << "Failed. Trying to open with make, model & serial no:" |
There was a problem hiding this comment.
make, model is hard to understand for me. How about:
Suggested change
| << "Failed. Trying to open with make, model & serial no:" | |
| << "Failed to open with ID (vendor product "serial"): |
| << "(This may only open the first of multiple identical devices.)"; | ||
| qCWarning(m_logBase) | ||
| << "Unable to open specific HID device" << getName() | ||
| << "Trying now with just make and model." |
There was a problem hiding this comment.
Suggested change
| << "Trying now with just make and model." | |
| << "Trying now with just vendor and product ID." |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this fix
With this fix
I'm not very expert with
QDebugformatting, so all ears for some improvement there! (remove the"or space at the left of:for example)