Skip to content

Commit

Permalink
UPSTREAM: HID: playstation: fix return from dualsense_player_led_set_…
Browse files Browse the repository at this point in the history
…brightness()

brightness_set_blocking() callback expects function returning int. This fixes
the follwoing build failure:

drivers/hid/hid-playstation.c: In function ‘dualsense_player_led_set_brightness’:
drivers/hid/hid-playstation.c:885:1: error: no return statement in function returning non-void [-Werror=return-type]
 }
 ^

Signed-off-by: Jiri Kosina <[email protected]>

Bug: 260685629
(cherry picked from commit 3c92cb4)
Change-Id: Id16b960826a26ac22c1a14572444f9af29689ed6
Signed-off-by: Farid Chahla <[email protected]>
  • Loading branch information
Jiri Kosina authored and Treehugger Robot committed Dec 20, 2022
1 parent f7901b4 commit 6296465
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions drivers/hid/hid-playstation.c
Original file line number Diff line number Diff line change
Expand Up @@ -882,6 +882,8 @@ static int dualsense_player_led_set_brightness(struct led_classdev *led, enum le
spin_unlock_irqrestore(&ds->base.lock, flags);

schedule_work(&ds->output_worker);

return 0;
}

static void dualsense_init_output_report(struct dualsense *ds, struct dualsense_output_report *rp,
Expand Down

0 comments on commit 6296465

Please sign in to comment.