Skip to content

Commit

Permalink
Merge pull request leptos-rs#2611 from leptos-rs/failing-ci
Browse files Browse the repository at this point in the history
Fix failing CI
  • Loading branch information
gbj authored Jun 2, 2024
2 parents 96b4488 + ec19c59 commit 00a42da
Show file tree
Hide file tree
Showing 6 changed files with 14 additions and 16 deletions.
3 changes: 0 additions & 3 deletions .github/workflows/run-cargo-make-task.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,9 +48,6 @@ jobs:
- name: Install wasm-bindgen
run: cargo binstall wasm-bindgen-cli --no-confirm

- name: Install wasm-pack
run: cargo binstall wasm-pack --no-confirm

- name: Install cargo-leptos
run: cargo binstall cargo-leptos --no-confirm

Expand Down
2 changes: 2 additions & 0 deletions examples/cargo-make/deno-build.toml
Original file line number Diff line number Diff line change
@@ -1,9 +1,11 @@
[tasks.build]
install_crate = { crate_name = "wasm-pack", binary = "wasm-pack", test_arg = "--help" }
clear = true
command = "deno"
args = ["task", "build"]

[tasks.start-client]
install_crate = { crate_name = "wasm-pack", binary = "wasm-pack", test_arg = "--help" }
command = "deno"
args = ["task", "start"]

Expand Down
12 changes: 6 additions & 6 deletions examples/hackernews_js_fetch/Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@ lto = true
console_log = "1.0.0"
console_error_panic_hook = "0.1.7"
cfg-if = "1.0.0"
leptos = { version = "0.5" }
leptos_axum = { version = "0.5", default-features = false, optional = true }
leptos_meta = { version = "0.5" }
leptos_router = { version = "0.5" }
leptos = { path = "../../leptos" }
leptos_axum = { path = "../../integrations/axum", default-features = false, optional = true }
leptos_meta = { path = "../../meta" }
leptos_router = { path = "../../router" }
log = "0.4.17"
simple_logger = "4.0.0"
serde = { version = "1.0.148", features = ["derive"] }
tracing = "0.1"
gloo-net = { version = "0.4.0", features = ["http"] }
reqwest = { version = "0.11.13", features = ["json"] }
axum = { version = "0.6", default-features = false, optional = true }
axum = { version = "0.7", default-features = false, optional = true }
tower = { version = "0.4.13", optional = true }
http = { version = "0.2.11", optional = true }
web-sys = { version = "0.3", features = [
Expand All @@ -37,7 +37,7 @@ wasm-bindgen = "0.2"
wasm-bindgen-futures = { version = "0.4.37", features = [
"futures-core-03-stream",
], optional = true }
axum-js-fetch = { version = "0.2.1", optional = true }
axum-js-fetch = { git = "https://github.com/seanaye/axum-js-fetch", optional = true }
lazy_static = "1.4.0"

[features]
Expand Down
2 changes: 2 additions & 0 deletions examples/hackernews_js_fetch/rust-toolchain.toml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[toolchain]
channel = "stable" # test change
6 changes: 3 additions & 3 deletions examples/hackernews_js_fetch/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -62,8 +62,8 @@ mod ssr_imports {
let routes = generate_route_list(App);

// build our application with a route
let app: axum::Router<(), axum::body::Body> = Router::new()
.leptos_routes(&leptos_options, routes, || view! { <App/> })
let app: axum::Router<()> = Router::new()
.leptos_routes(&leptos_options, routes, App)
.route("/api/*fn_name", post(leptos_axum::handle_server_fns))
.with_state(leptos_options);

Expand All @@ -73,7 +73,7 @@ mod ssr_imports {
}

pub async fn serve(&self, req: web_sys::Request) -> web_sys::Response {
self.0.serve(req).await
self.0.oneshot(req).await
}
}
}
5 changes: 1 addition & 4 deletions router/src/matching/matcher.rs
Original file line number Diff line number Diff line change
Expand Up @@ -68,10 +68,7 @@ impl Matcher {
self.segments.iter().zip(loc_segments.iter())
{
if let Some(param_name) = segment.strip_prefix(':') {
params.insert(
param_name.into(),
unescape(*loc_segment).into(),
);
params.insert(param_name.into(), unescape(loc_segment));
} else if segment != loc_segment {
// if any segment doesn't match and isn't a param, there's no path match
return None;
Expand Down

0 comments on commit 00a42da

Please sign in to comment.