Respect cache timestamp format when giving timestamps to #cache_key

mjcloutier · Nov 4, 2013 · 92c6305 · 92c6305
1 parent 91d72fe
commit 92c6305
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/activerecord/lib/active_record/integration.rb b/activerecord/lib/active_record/integration.rb
@@ -56,7 +56,8 @@ def cache_key(*timestamp_names)
         "#{self.class.model_name.cache_key}/new"
       when timestamp_names.any?
         timestamps = timestamp_names.collect { |method| send(method) }.compact
-        "#{self.class.model_name.cache_key}/#{id}-#{timestamps.max.utc.to_s(:number)}"
+        timestamp = timestamps.max.utc.to_s(cache_timestamp_format)
+        "#{self.class.model_name.cache_key}/#{id}-#{timestamp}"
       when timestamp = max_updated_column_timestamp
         timestamp = timestamp.utc.to_s(cache_timestamp_format)
         "#{self.class.model_name.cache_key}/#{id}-#{timestamp}"

diff --git a/activerecord/test/cases/integration_test.rb b/activerecord/test/cases/integration_test.rb
@@ -82,9 +82,9 @@ def test_cache_key_format_is_precise_enough
     dev.touch
     assert_not_equal key, dev.cache_key
   end
-  
+
   def test_named_timestamps_for_cache_key
     owner = owners(:blackbeard)
-    assert_equal "owners/#{owner.id}-#{owner.happy_at.utc.to_s(:number)}", owner.cache_key(:updated_at, :happy_at)
+    assert_equal "owners/#{owner.id}-#{owner.happy_at.utc.to_s(:nsec)}", owner.cache_key(:updated_at, :happy_at)
   end
 end