Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to add Debian Bookworm build #49

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

prulloac
Copy link
Contributor

To address issue #44 , I've come up with this pull request. It was easy enough to add debian bookworm build, but for older debian versions such as bullseye or buster, it will be a bit trickier because those versions do not have either libadwaita-1-dev nor libgtk-4-dev. I'll try to address those in a follow-up pull request

@mkasberg
Copy link
Owner

This looks very close! Thanks for the contribution.

I tried installing the package in a Bookworm VM and it's failing with this error:

Unpacking ghostty (1.0.1-0~ppa3) ...
dpkg: dependency problems prevent configuration of ghostty:
 ghostty depends on libglib2.0-0t64; however:
  Package libglib2.0-0t64 is not installed.

In Debian Bookworm, it looks like the package is libglib2.0-0. We'll need to remove the t64 bit. We already do this for Ubuntu 22.04, we should do the same for Debian Bookworm. Basically, just update this if:

# Package name changed after 22.04
if [ "$UBUNTU_VERSION" = "22.04" ]; then
sed -i "s/libglib2.0-0t64/libglib2.0-0/" zig-out/DEBIAN/control
fi

@prulloac
Copy link
Contributor Author

Cool, will try it. How about also adding a test step to install on a container after building the .deb ?, that way this could've been found without the manual installment

@alexeyten
Copy link

maybe just use alternate dependency?

Depends: ..., libglib2.0-0t64 | libglib2.0-0, ...

@mkasberg
Copy link
Owner

Good suggestion about the tests, I'll work on that as I have time!

The alternative dependency seems like a good suggestion, possibly better than what's already in place. I'm open to switching to that.

Copy link
Owner

@mkasberg mkasberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the contribution! I believe you'll be able to download a .deb artifact from this PR's build if you want, otherwise I'll try to push out a release within the next couple days.

@mkasberg mkasberg merged commit 2de24d4 into mkasberg:main Jan 20, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants