Add hf tokenizer class definition header #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
The current implementation of the HFTokenizer has specialized methods that expose the add_special_tokens flag. However these are inside the .cc file and are not exposed as part of the api/cmake includes
Fix:
This splits the definition and instantiation of the HFTokenizer, allowing me to place the definition in the header file (I placed in tokenizers_cpp.h )
I also added/moved the factory methods for constructing the derived HFTokenizer class into HFTokenizer, and then had the base classes factory call those (allowing for implicit conversion of the unique pointer from HFTokenizer to Tokenizer.)