Add check for the not-yet-implemented functionality of selecting variables from different coord levels in the same input dataset #65
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
The current implementation of selection of variables by coordinate values does not, within one input dataset, support the selection of variables from different coordinate levels. E.g. the following selection
would currently add
u100m
,u50m
,v100m
,v50m
,t100m
,t50m
to the output dataset. So it results in missing variables (v75m
andt30m
) but also adds extra variables (v50m
,t100m
andt50m
), which all are just nans. Such a selection is something we would like to support but the current implementation does not.Implementing the support of such a selection would require changes to the way that the selected (and derived) variables are collected (currently in one dataset before merging and dimension mapping). Until such a time, this PR adds a
NotImplementedError
exception invalidate_config
if one tries to do a selection of variables on different coordinate values within one input dataset. It also adds a section to the README with an explanation of the allowed selections and how to do the selection of variables on different coordinate values.I have also added tests to check that the exceptions raised in
validate_config
are correctly caught.No change in dependencies needed for this change.
Issue Link
Addresses #61.
Type of change
Checklist before requesting a review
pull
with--rebase
option if possible).Checklist for reviewers
Each PR comes with its own improvements and flaws. The reviewer should check the following:
Author checklist after completed review
reflecting type of change (add section where missing):
Checklist for assignee