Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass failing commands via studio API #2140

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Pass failing commands via studio API #2140

wants to merge 1 commit into from

Conversation

jotoh98
Copy link

@jotoh98 jotoh98 commented Nov 14, 2024

Proposed changes

copilot:summary

Testing

  • built locally
  • ran failing and succeeding assertion

Issues fixed

@Fishbowler
Copy link
Contributor

This has bothered folks for a while! Thanks!

@Fishbowler Fishbowler self-requested a review December 30, 2024 12:07
@Fishbowler Fishbowler force-pushed the fix/studio-error-handling branch from 8e4443f to 31b09db Compare December 30, 2024 12:10
@Fishbowler
Copy link
Contributor

Rebased

Fishbowler
Fishbowler approved these changes Dec 31, 2024
View reviewed changes
Copy link
Contributor

@Fishbowler Fishbowler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my machine!
Had a play with some simple stuff like assertTrue, assertVisible and tapOn. Also some hairier stuff like launchApp.
All give the expected outcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fishbowler Fishbowler Fishbowler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jotoh98 @Fishbowler